From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2BFEC4727D for ; Wed, 23 Sep 2020 00:29:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B41B2085B for ; Wed, 23 Sep 2020 00:29:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="TvX//jms" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727118AbgIWA30 (ORCPT ); Tue, 22 Sep 2020 20:29:26 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:49504 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726583AbgIWA30 (ORCPT ); Tue, 22 Sep 2020 20:29:26 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08N0Ss4D100635; Wed, 23 Sep 2020 00:29:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : message-id : references : date : in-reply-to : mime-version : content-type; s=corp-2020-01-29; bh=p4AKAKCBmfCn4yWHVUiNN9DjkVKaWkjjVtV3bQAGiMs=; b=TvX//jmsCz6mMHRL6054fB80aSfMZfnak9sINRf/580oI+r/WsDAJb+dGKodJb9bd0N6 sjbGcWMy6vjMcJ/OhDlvZuXHYbTk0w9gLRLewwyAZBpY06Yp4vkz1VUvmzc9pEAera0l cLAYi3l4xfD3V7Uc6T4uHe2/trmcGhgUEXqxQJEtvlaXAZl2Y1s23wWNaJtz0WQlbQFg CLGL6K6fUhin/26xn+nIP+6YmSGjpXGKWI1Ycqz3pqtnt7td7Z7mSDywcj9BJCN3mQCJ d/CWzmvfbc2xqLTGifJ/ja2chGfcbS6ENLhijK16qqC9clh3++XFEzD7vjzVa51cV5zJ QA== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 33ndnufrev-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 23 Sep 2020 00:29:09 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08N0Pbc8057119; Wed, 23 Sep 2020 00:29:09 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3030.oracle.com with ESMTP id 33nux08myg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Sep 2020 00:29:08 +0000 Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 08N0T6Hr015119; Wed, 23 Sep 2020 00:29:06 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 22 Sep 2020 17:29:06 -0700 To: Qinglang Miao Cc: Nilesh Javali , Manish Rangankar , , "James E.J. Bottomley" , "Martin K. Petersen" , , Subject: Re: [PATCH -next] scsi: bnx2i: remove unnecessary mutex_init() From: "Martin K. Petersen" Organization: Oracle Corporation Message-ID: References: <20200916062133.191000-1-miaoqinglang@huawei.com> Date: Tue, 22 Sep 2020 20:29:03 -0400 In-Reply-To: <20200916062133.191000-1-miaoqinglang@huawei.com> (Qinglang Miao's message of "Wed, 16 Sep 2020 14:21:33 +0800") MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9752 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 adultscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 suspectscore=1 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009230000 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9752 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 phishscore=0 adultscore=0 suspectscore=1 bulkscore=0 clxscore=1011 impostorscore=0 mlxlogscore=999 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009230000 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Qinglang, > The mutex bnx2i_dev_lock is initialized statically. It is > unnecessary to initialize by mutex_init(). Applied to 5.10/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering