From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751923AbeADDxU (ORCPT + 1 other); Wed, 3 Jan 2018 22:53:20 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:36208 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751584AbeADDxS (ORCPT ); Wed, 3 Jan 2018 22:53:18 -0500 To: Colin King Cc: James Smart , Dick Kennedy , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: lpfc: don't dereference localport before it has been null checked From: "Martin K. Petersen" Organization: Oracle Corporation References: <20171222002852.10892-1-colin.king@canonical.com> Date: Wed, 03 Jan 2018 22:53:10 -0500 In-Reply-To: <20171222002852.10892-1-colin.king@canonical.com> (Colin King's message of "Fri, 22 Dec 2017 00:28:52 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8763 signatures=668651 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=555 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1801040050 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Colin, > localport is being dereferenced to assign lport and then immediately > afterwards localport is being sanity checked to see if it is null. > Fix this by only dereferencing localport until after it has been > null checked. Applied to 4.16/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering