From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751431AbcCACJT (ORCPT ); Mon, 29 Feb 2016 21:09:19 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:22703 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750866AbcCACJR (ORCPT ); Mon, 29 Feb 2016 21:09:17 -0500 To: Nicholas Krause Cc: jayamohan.kallickal@avagotech.com, ketan.mukadam@avagotech.com, sony.john@avagotech.com, James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] be2iscsi:Add missing error check in beiscsi_eeh_resume From: "Martin K. Petersen" Organization: Oracle Corporation References: <1456595005-13281-1-git-send-email-xerofoify@gmail.com> Date: Mon, 29 Feb 2016 21:09:03 -0500 In-Reply-To: <1456595005-13281-1-git-send-email-xerofoify@gmail.com> (Nicholas Krause's message of "Sat, 27 Feb 2016 12:43:25 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Nicholas" == Nicholas Krause writes: Nicholas> This adds the missing error check and path for if the call to Nicholas> the function hwi_init_controller fails as this error path was Nicholas> clearly missed when writing beiscsi_eeh_resume and thus we Nicholas> must add it now in order to be able to handle this Nicholas> nonrecoverable failing function call gracefully in Nicholas> beiscsi_eeh_resume. Applied to 4.6/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering