From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752239AbcBJR37 (ORCPT ); Wed, 10 Feb 2016 12:29:59 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:51567 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751840AbcBJR35 (ORCPT ); Wed, 10 Feb 2016 12:29:57 -0500 To: Denys Vlasenko Cc: James Bottomley , Fabian Frederick , Anil Gurumurthy , Christoph Hellwig , Guenter Roeck , Ben Hutchings , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH RESEND] bfa: deinline __bfa_trc() and __bfa_trc32() From: "Martin K. Petersen" Organization: Oracle Corporation References: <1454618448-1381-1-git-send-email-dvlasenk@redhat.com> Date: Wed, 10 Feb 2016 12:28:49 -0500 In-Reply-To: <1454618448-1381-1-git-send-email-dvlasenk@redhat.com> (Denys Vlasenko's message of "Thu, 4 Feb 2016 21:40:48 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Denys" == Denys Vlasenko writes: Denys> __bfa_trc32() is very similar, so it is uninlined too. However, Denys> it appears to be unused, therefore this patch ifdefs it out. Why don't we just drop it? -- Martin K. Petersen Oracle Linux Engineering