mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Hannes Reinecke <hare@suse.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
	"Darrick J. Wong" <darrick.wong@oracle.com>,
	chuck.lever@oracle.com, Christoph Hellwig <hch@infradead.org>,
	Jens Axboe <axboe@kernel.dk>,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: status of block-integrity
Date: Wed, 08 Jan 2014 10:23:51 -0500	[thread overview]
Message-ID: <yq1lhyqv6ns.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <52CCFADB.6080909@suse.de> (Hannes Reinecke's message of "Wed, 08 Jan 2014 08:14:35 +0100")

>>>>> "Hannes" == Hannes Reinecke <hare@suse.de> writes:

Hannes,

Hannes> As there is no user (apart from oracleasm) no-one can attach
Hannes> protection information to any data, so even the most dedicated
Hannes> admin cannot exercise this path, let alone find issues here.

That's not how it works!

If the filesystem has not attached protection information to a bio the
block layer will do it for you. The block layer generates protection
information for writes and verifies it for reads. That's how it's worked
since day one. The code is there, it is used by everyone with a
DIX-capable HBA. See Documentation/block/data-integrity.txt.

Normal applications do not want to have to deal with generating
protection information, using an async I/O model, keeping completion
state around for extended periods of time to figure out whether the I/O
actually completed or not and so on. So the kernel-to-platter protection
scheme we have in place now is good enough.

That doesn't mean that I'm not interested in augmenting libaio. I
am. Very. And I know of several applications that are keen to use
it. But getting page cache passthrough and filesystem interaction
working is non-trivial. That's what has inhibited progress, not
extending the libaio API.

Hannes> Doug Gilbert and I are currently discussing LID4 / ROD Token
Hannes> copy for sg3_utils and the block layer, so any patches would be
Hannes> very helpful here.

I'm only doing LID1 right now. Any particular reason you are exploring
LID4 and ROD?

I resumed my efforts before Christmas but I keep running into issues.
I'm guessing I'm a week or two from having something that is suitable
for consumption.

-- 
Martin K. Petersen	Oracle Linux Engineering

  reply	other threads:[~2014-01-08 15:24 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-22 19:21 Christoph Hellwig
2013-12-22 20:45 ` Nicholas A. Bellinger
2013-12-23 13:35 ` Martin K. Petersen
2013-12-23 13:48   ` Christoph Hellwig
2013-12-31 19:41   ` berthiaume, wayne
2014-01-07  8:28   ` Ric Wheeler
2014-01-07 13:33     ` Hannes Reinecke
2014-01-07 23:34       ` Matthew Wilcox
2014-01-08  0:05         ` James Bottomley
2014-01-08 15:43           ` Martin K. Petersen
2014-01-03 15:01 ` Hannes Reinecke
2014-01-03 20:03   ` Martin K. Petersen
2014-01-07  1:36     ` Darrick J. Wong
2014-01-07  7:17       ` Hannes Reinecke
2014-01-07 21:43         ` Martin K. Petersen
2014-01-08  7:14           ` Hannes Reinecke
2014-01-08 15:23             ` Martin K. Petersen [this message]
2014-01-09 11:19               ` Hannes Reinecke
2014-01-10  1:49                 ` Martin K. Petersen
2014-01-07 15:06       ` Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1lhyqv6ns.fsf@sermon.lab.mkp.net \
    --to=martin.petersen@oracle.com \
    --cc=axboe@kernel.dk \
    --cc=chuck.lever@oracle.com \
    --cc=darrick.wong@oracle.com \
    --cc=hare@suse.de \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®