From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Pankaj Raghav <p.raghav@samsung.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
Christian Brauner <brauner@kernel.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
<linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kernel@pankajraghav.com>
Subject: Re: [PATCH] fs/buffer: fix comments to reflect logical block size
Date: Tue, 17 Jun 2025 21:48:50 -0400 [thread overview]
Message-ID: <yq1msa5x218.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20250617115138.101795-1-p.raghav@samsung.com> (Pankaj Raghav's message of "Tue, 17 Jun 2025 13:51:38 +0200")
Hi Pankaj!
> - /* Size must be multiple of hard sectorsize */
> + /* Size must be multiple of logical block size */
> if (unlikely(size & (bdev_logical_block_size(bdev)-1) ||
> (size < 512 || size > PAGE_SIZE))) {
> printk(KERN_ERR "getblk(): invalid block size %d requested\n",
OK with me. However, maybe that comment should just go away? The code on
the following line articulates the constraint very clearly.
If you tweak things, please fix the spacing for "(bdev)-1".
Either way:
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen
next prev parent reply other threads:[~2025-06-18 1:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 11:51 Pankaj Raghav
2025-06-18 1:48 ` Martin K. Petersen [this message]
2025-06-18 7:57 ` Pankaj Raghav (Samsung)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1msa5x218.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=kernel@pankajraghav.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.raghav@samsung.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®