From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Yuchen Yang <u202114568@hust.edu.cn>
Cc: Adam Radford <aradford@gmail.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
hust-os-kernel-patches@googlegroups.com,
Dan Carpenter <dan.carpenter@linaro.org>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: scsi: 3w-xxxx: Add error handling for initialization failure in `tw_probe`
Date: Mon, 22 May 2023 17:40:52 -0400 [thread overview]
Message-ID: <yq1mt1wnixx.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20230505141259.7730-1-u202114568@hust.edu.cn> (Yuchen Yang's message of "Fri, 5 May 2023 22:12:55 +0800")
Yuchen,
> Smatch complains that:
> tw_probe() warn: missing error code 'retval'
>
> This patch adds error checking to `tw_probe` function to handle
> initialization failure. If `tw_reset_sequence` function returns a
> non-zero value, the function will return an `-EINVAL` error code
> to indicate the initialization failure.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Yuchen Yang <u202114568@hust.edu.cn>
> Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Applied to 6.5/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2023-05-22 21:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 14:12 Yuchen Yang
2023-05-22 21:40 ` Martin K. Petersen [this message]
2023-06-01 0:43 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1mt1wnixx.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=aradford@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=hust-os-kernel-patches@googlegroups.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=u202114568@hust.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®