From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752904AbcG2BXi (ORCPT ); Thu, 28 Jul 2016 21:23:38 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:38288 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752143AbcG2BXg (ORCPT ); Thu, 28 Jul 2016 21:23:36 -0400 To: Calvin Owens Cc: "James E.J. Bottomley" , "Martin K. Petersen" , , Subject: Re: [PATCH] ses: Fix racy cleanup of /sys in remove_dev() From: "Martin K. Petersen" Organization: Oracle Corporation References: <4912ec551a8ec01181cc3e7ad1e01d3d36758810.1463170976.git.calvinowens@fb.com> <5750B821.7010600@fb.com> <20160615202416.GA52103@calvinowens-mba.dhcp.thefacebook.com> <617c5fc1-ecc5-c825-ecb9-eeae2b637dfd@fb.com> Date: Thu, 28 Jul 2016 21:23:26 -0400 In-Reply-To: <617c5fc1-ecc5-c825-ecb9-eeae2b637dfd@fb.com> (Calvin Owens's message of "Wed, 27 Jul 2016 18:04:12 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Calvin" == Calvin Owens writes: >> Any thoughts? Squinting at this more it still seems racy, but a >> narrow race is surely better than just blatantly freeing everything >> while the file is still exposed in /sys? Is there a better way you'd >> prefer I accomplish this? >> >> (I have boxes that OOPS all the time from monitoring code reading the >> /sys files, with this patch I haven't seen a single one.) Calvin> Ping? Thoughts, comments? James: This is your puppy... -- Martin K. Petersen Oracle Linux Engineering