From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753867AbcAHCwf (ORCPT ); Thu, 7 Jan 2016 21:52:35 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:29565 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752634AbcAHCwe (ORCPT ); Thu, 7 Jan 2016 21:52:34 -0500 To: Insu Yun Cc: brking@us.ibm.com, JBottomley@odin.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, taesoo@gatech.edu, yeongjin.jang@gatech.edu, insu@gatech.edu, changwoo@gatech.edu, Shane Seymour Subject: Re: [PATCH v3] ipr: fix out-of-bounds null overwrite From: "Martin K. Petersen" Organization: Oracle Corporation References: <1452102241-4732-1-git-send-email-wuninsu@gmail.com> Date: Thu, 07 Jan 2016 21:52:18 -0500 In-Reply-To: <1452102241-4732-1-git-send-email-wuninsu@gmail.com> (Insu Yun's message of "Wed, 6 Jan 2016 12:44:01 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Insu" == Insu Yun writes: Insu> Return value of snprintf is not bound by size value, 2nd argument. Insu> (https://www.kernel.org/doc/htmldocs/kernel-api/API-snprintf.html). Insu> Return value is number of printed chars, can be larger than 2nd Insu> argument. Therefore, it can write null byte out of bounds Insu> ofbuffer. Since snprintf puts null, it does not need to put Insu> additional null byte. Applied to 4.5/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering