From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Lukas Czerner <lczerner@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Dmitry Monakhov <dmonakhov@openvz.org>,
Jens Axboe <jaxboe@fusionio.com>
Subject: Re: [PATCH 3/3] blkdev: honor discard_granularity in blkdev_issue_discard()
Date: Mon, 02 May 2011 13:07:27 -0400 [thread overview]
Message-ID: <yq1pqo12fqo.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <x49aaf5ozge.fsf@segfault.boston.devel.redhat.com> (Jeff Moyer's message of "Mon, 02 May 2011 12:10:41 -0400")
>>>>> "Jeff" == Jeff Moyer <jmoyer@redhat.com> writes:
Jeff> Hm, I wonder where it makes sense to document this. Maybe
Jeff> Documentation/block/queue-sysfs.txt, but I admit I wouldn't have
Jeff> looked there while reviewing this code.
Maybe we could simply add a comment in the kerneldoc header for
blkdev_issue_discard()?
I tried to keep Documentation/ABI/ up to date for the topology stuff but
it looks like the discard portions never got merged. Probably fell
through the cracks. I'll dig up the patch.
But as you say -- I'm sure nobody looks. My only motivation for keeping
the sysfs ABI doc in sync is to avoid gregkh's wrath...
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2011-05-02 17:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-02 14:17 [PATCH 1/3] blkdev: Submit discard bio in batches " Lukas Czerner
2011-05-02 14:17 ` [PATCH 2/3] blkdev: Simple cleanup in blkdev_issue_zeroout() Lukas Czerner
2011-05-02 14:17 ` [PATCH 3/3] blkdev: honor discard_granularity in blkdev_issue_discard() Lukas Czerner
2011-05-02 14:38 ` Martin K. Petersen
2011-05-02 16:10 ` Jeff Moyer
2011-05-02 17:07 ` Martin K. Petersen [this message]
2011-05-02 23:21 ` Dave Chinner
2011-05-02 16:23 ` [PATCH 1/3] blkdev: Submit discard bio in batches " Jens Axboe
2011-05-03 9:30 ` Lukas Czerner
2011-05-03 9:57 ` Christoph Hellwig
2011-05-07 1:23 ` Jens Axboe
2011-05-05 15:20 ` Lukas Czerner
2011-05-07 1:24 ` Jens Axboe
2011-05-09 14:30 ` Christoph Hellwig
2011-05-05 15:12 ` [PATCH] blkdev: Do not return -EOPNOTSUPP if discard is supported Lukas Czerner
2011-05-07 1:30 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1pqo12fqo.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=dmonakhov@openvz.org \
--cc=jaxboe@fusionio.com \
--cc=jmoyer@redhat.com \
--cc=lczerner@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®