From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: jinxiaobo <jinxiaobo@uniontech.com>
Cc: jejb@linux.ibm.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: sr: Fix some cdroms automatically ejected when booting into the system
Date: Wed, 27 Apr 2022 22:51:02 -0400 [thread overview]
Message-ID: <yq1sfpxkjpo.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20220427090906.2257940-1-jinxiaobo@uniontech.com> (jinxiaobo@uniontech.com's message of "Wed, 27 Apr 2022 17:09:06 +0800")
Hi jinxiaobo!
> sr_get_events() has been called before udev starts when SCSI CDROM is
> built-in and AHCI SATA is bulit-in,so sr events propagated to user
> space are not handled. if both is loadable, udev will handle sr
> events, some cdroms may eject. We need call sr_get_events() once
> before device_add_disk() to keep the same result, whether both are
> built-in or loadable.
I am not sure how calling sr_get_events() and throwing away the result
ensures that events get propagated to udev. Isn't this just changing
timing slightly?
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2022-04-28 2:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 9:09 jinxiaobo
2022-04-28 2:51 ` Martin K. Petersen [this message]
2022-05-05 3:01 ` job jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1sfpxkjpo.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=jejb@linux.ibm.com \
--cc=jinxiaobo@uniontech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®