From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753216AbcISUqd (ORCPT ); Mon, 19 Sep 2016 16:46:33 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:45482 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752803AbcISUq3 (ORCPT ); Mon, 19 Sep 2016 16:46:29 -0400 To: Christoph Hellwig Cc: hans.verkuil@cisco.com, brking@us.ibm.com, haver@linux.vnet.ibm.com, ching2048@areca.com.tw, axboe@fb.com, alex.williamson@redhat.com, kvm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-block@vger.kernel.org, linux-media@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] arcmsr: use pci_alloc_irq_vectors From: "Martin K. Petersen" Organization: Oracle Corporation References: <1473600688-24043-1-git-send-email-hch@lst.de> <1473600688-24043-2-git-send-email-hch@lst.de> Date: Mon, 19 Sep 2016 16:45:42 -0400 In-Reply-To: <1473600688-24043-2-git-send-email-hch@lst.de> (Christoph Hellwig's message of "Sun, 11 Sep 2016 15:31:23 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Christoph" == Christoph Hellwig writes: Christoph> Switch the arcmsr driver to use pci_alloc_irq_vectors. We Christoph> need to two calls to pci_alloc_irq_vectors as arcmsr only Christoph> supports multiple MSI-X vectors, but not multiple MSI Christoph> vectors. Christoph> Otherwise this cleans up a lot of cruft and allows to use a Christoph> common request_irq loop for irq types, which happens to only Christoph> iterate over a single line in the non MSI-X case. Ching: Please test and review. Thanks! -- Martin K. Petersen Oracle Linux Engineering