From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752816Ab0FGRkn (ORCPT ); Mon, 7 Jun 2010 13:40:43 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:30590 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751847Ab0FGRkl (ORCPT ); Mon, 7 Jun 2010 13:40:41 -0400 To: Boaz Harrosh Cc: "Martin K. Petersen" , Dave Chinner , Christof Schmitt , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: Wrong DIF guard tag on ext2 write From: "Martin K. Petersen" Organization: Oracle References: <20100531112817.GA16260@schmichrtp.mainz.de.ibm.com> <20100531144648.GA19068@schmichrtp.mainz.de.ibm.com> <20100602133748.GA11196@schmichrtp.mainz.de.ibm.com> <20100602232039.GA8287@dastard> <20100604023253.GF19651@dastard> <4C0D2AD4.2020303@panasas.com> Date: Mon, 07 Jun 2010 13:40:21 -0400 In-Reply-To: <4C0D2AD4.2020303@panasas.com> (Boaz Harrosh's message of "Mon, 07 Jun 2010 20:22:28 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Auth-Type: Internal IP X-Source-IP: acsinet15.oracle.com [141.146.126.227] X-CT-RefId: str=0001.0A090208.4C0D2F11.0173:SCFMA922111,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Boaz" == Boaz Harrosh writes: Boaz> Do you remember some performance numbers that show degradation / Boaz> sameness? Boaz> What type of work loads? I haven't been using XFS much for over a year. I'm using an internal async I/O tool and btrfs for most of my DIX/DIF testing these days. But my original changes were along the lines of what Jan mentioned earlier (hooking into page_mkwrite and waiting for writeback. I could have sworn that I only did it for ext[23] and that XFS waited out of the box but git proves me wrong). Anyway, I'll try to get some benchmarking happening later this week. This won't fix things completely, though. ext2fs, for instance, frequently changes metadata buffers in flight so it trips the guard check in no time. -- Martin K. Petersen Oracle Linux Engineering