From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752809AbcA0CTl (ORCPT ); Tue, 26 Jan 2016 21:19:41 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:19476 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751177AbcA0CTi (ORCPT ); Tue, 26 Jan 2016 21:19:38 -0500 To: John Garry Cc: , , , , , , Subject: Re: [PATCH] hisi_sas: fix v1 hw check for slot error From: "Martin K. Petersen" Organization: Oracle Corporation References: <1453829477-40725-1-git-send-email-john.garry@huawei.com> Date: Tue, 26 Jan 2016 21:19:29 -0500 In-Reply-To: <1453829477-40725-1-git-send-email-john.garry@huawei.com> (John Garry's message of "Wed, 27 Jan 2016 01:31:17 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "John" == John Garry writes: John> Completion header bit CMPLT_HDR_RSPNS_XFRD flags whether the John> response frame is received into host memory, and not whether the John> response frame has an error. As such, change the decision on John> whether a slot has an error. Also redundant check on John> CMPLT_HDR_CMD_CMPLT_MSK is removed. Applied to 4.5/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering