From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Sreekanth Reddy <sreekanth.reddy@avagotech.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
"jejb\@kernel.org" <jejb@kernel.org>,
Christoph Hellwig <hch@infradead.org>,
"linux-scsi\@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"James E.J. Bottomley" <JBottomley@parallels.com>,
Sathya Prakash <Sathya.Prakash@avagotech.com>,
Nagalakshmi Nandigama <Nagalakshmi.Nandigama@avagotech.com>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 06/22] [SCSI] mpt2sas, mpt3sas: Removing uppper boundary restriction for the module parameter max_sgl_entries
Date: Tue, 06 Jan 2015 19:17:32 -0500 [thread overview]
Message-ID: <yq1tx0378bn.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <CAK=zhgrr=9+3dynE6fuTikNwnBFKe5x=jA+UTzPKqfNAyXt_ow@mail.gmail.com> (Sreekanth Reddy's message of "Thu, 11 Dec 2014 17:44:03 +0530")
>>>>> "Sreekanth" == Sreekanth Reddy <sreekanth.reddy@avagotech.com> writes:
Sreekanth> I though to warn the user that the module parameter
Sreekanth> max_sgl_entries value what they provided is greater than the
Sreekanth> kernel defined SCSI_MAX_SG_SEGMENTS, whether if this module
Sreekanth> parameter value is greater than or less than the
Sreekanth> SCSI_MAX_SG_CHAIN_SEGMENTS. Also I thought, user may confuse
Sreekanth> if see observes SCSI_MAX_SG_CHAIN_SEGMENTS value instead of
Sreekanth> max_sgl_entries value in the warning message.
I would just prefer to see the value that is in effect. I know what I
provided as override value.
At the very least print a warning if you subsequently clamp the value to
MAX_SG_CHAIN_SEGMENTS. "Requested number of segments %u is bigger than
kernel max %u".
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2015-01-07 0:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 13:27 Sreekanth Reddy
2014-12-10 20:52 ` Martin K. Petersen
2014-12-11 12:14 ` Sreekanth Reddy
2015-01-07 0:17 ` Martin K. Petersen [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-01-07 12:53 Sreekanth Reddy
2015-01-09 20:55 ` Martin K. Petersen
2014-11-20 7:05 [PATCH 00/22] mpt2sas, mpt3sas: SAS2 Phase 19,20 and SAS3 Phase 4,5 patches Sreekanth Reddy
2014-11-20 7:05 ` [PATCH 06/22] [SCSI] mpt2sas, mpt3sas: Removing uppper boundary restriction for the module parameter max_sgl_entries Sreekanth Reddy
2014-12-04 3:05 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1tx0378bn.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=JBottomley@parallels.com \
--cc=Nagalakshmi.Nandigama@avagotech.com \
--cc=Sathya.Prakash@avagotech.com \
--cc=hch@infradead.org \
--cc=jejb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sreekanth.reddy@avagotech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®