From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: jejb@linux.vnet.ibm.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
arnd@arndb.de, xie.baoyou@zte.com.cn
Subject: Re: [PATCH v2] scsi: move function declarations to scsi_priv.h
Date: Wed, 31 Aug 2016 00:29:06 -0400 [thread overview]
Message-ID: <yq1vayh5zot.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <1472556360-22313-1-git-send-email-baoyou.xie@linaro.org> (Baoyou Xie's message of "Tue, 30 Aug 2016 19:26:00 +0800")
>>>>> "Baoyou" == Baoyou Xie <baoyou.xie@linaro.org> writes:
Baoyou> We get 2 warnings about global functions without a declaration
Baoyou> in the scsi driver when building with W=1:
Baoyou> drivers/scsi/scsi_lib.c:467:6: warning: no previous prototype
Baoyou> for 'scsi_requeue_run_queue' [-Wmissing-prototypes]
Baoyou> drivers/scsi/scsi_lib.c:2609:6: warning: no previous prototype
Baoyou> for 'scsi_evt_thread' [-Wmissing-prototypes]
Baoyou> in fact, both functions are declared in drivers/scsi/scsi_scan.c
Baoyou> but need to move them into scsi_priv.h.
Applied to 4.9/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2016-08-31 4:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 11:26 Baoyou Xie
2016-08-31 4:29 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1vayh5zot.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®