From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Cc: Yihang Li <liyihang9@huawei.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: Don't use %pK through printk
Date: Mon, 16 Jun 2025 14:34:57 -0400 [thread overview]
Message-ID: <yq1wm9bzgah.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20250611-restricted-pointers-scsi-v1-1-fe31bfbc4910@linutronix.de> ("Thomas =?utf-8?Q?Wei=C3=9Fschuh=22's?= message of "Wed, 11 Jun 2025 11:58:06 +0200")
Thomas,
> In the past %pK was preferable to %p as it would not leak raw pointer
> values into the kernel log. Since commit ad67b74d2469 ("printk: hash
> addresses printed with %p") the regular %p has been improved to avoid
> this issue. Furthermore, restricted pointers ("%pK") were never meant
> to be used through printk(). They can still unintentionally leak raw
> pointers or acquire sleeping locks in atomic contexts.
Applied to 6.17/scsi-staging, thanks!
--
Martin K. Petersen
next prev parent reply other threads:[~2025-06-16 18:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 9:58 Thomas Weißschuh
2025-06-16 18:34 ` Martin K. Petersen [this message]
2025-06-20 3:18 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1wm9bzgah.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=liyihang9@huawei.com \
--cc=thomas.weissschuh@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®