mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: "Michael L. Semon" <mlsemon35@gmail.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-kernel@vger.kernel.org, axboe@fb.com
Subject: Re: Slow dc3dd in 3.18 on x86
Date: Fri, 24 Oct 2014 21:51:12 -0400	[thread overview]
Message-ID: <yq1wq7osyr3.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <544AEEF1.30506@gmail.com> (Michael L. Semon's message of "Fri, 24 Oct 2014 20:29:37 -0400")

>>>>> "Michael" == Michael L Semon <mlsemon35@gmail.com> writes:

Michael> There was nothing regarding integrity in /sys/block/sda.  I was
Michael> under the impression that both bio integrity and T10 checksums
Michael> require hardware support from good hardware, so the config
Michael> items have always been shut off. 

That's correct. But I see what's going on.

Please try this:

commit 8d331952d2cd341d5c0e64eee961f78f6eb4b968
Author: Martin K. Petersen <martin.petersen@oracle.com>
Date:   Fri Oct 24 21:39:12 2014 -0400

    block: Fix merge logic when CONFIG_BLK_DEV_INTEGRITY is not defined

    Commit 4eaf99beadce switched to returning bool and as a result
    reversed the logic of the integrity merge checks.  However, the
    empty stubs used when the block integrity code is compiled out were
    still returning 0. Make these stubs return "true".

    Reported-by: Michael L. Semon <mlsemon35@gmail.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 9fbf4d3196ed..7442c6b9187e 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1590,13 +1590,13 @@ static inline bool blk_integrity_merge_rq(struct request_queue *rq,
 					  struct request *r1,
 					  struct request *r2)
 {
-	return 0;
+	return true;
 }
 static inline bool blk_integrity_merge_bio(struct request_queue *rq,
 					   struct request *r,
 					   struct bio *b)
 {
-	return 0;
+	return true;
 }
 static inline bool blk_integrity_is_initialized(struct gendisk *g)
 {


  reply	other threads:[~2014-10-25  1:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-24 19:05 Michael L. Semon
2014-10-24 19:12 ` Martin K. Petersen
2014-10-24 19:54 ` Martin K. Petersen
2014-10-25  0:29   ` Michael L. Semon
2014-10-25  1:51     ` Martin K. Petersen [this message]
2014-10-25  6:37       ` Michael L. Semon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1wq7osyr3.fsf@sermon.lab.mkp.net \
    --to=martin.petersen@oracle.com \
    --cc=axboe@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mlsemon35@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome