From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932213AbeBGB0e (ORCPT ); Tue, 6 Feb 2018 20:26:34 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:42296 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754189AbeBGB0c (ORCPT ); Tue, 6 Feb 2018 20:26:32 -0500 To: Colin King Cc: Johannes Thumshirn , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: libfc: remove redundant initialization of 'disc' From: "Martin K. Petersen" Organization: Oracle Corporation References: <20180206142157.32001-1-colin.king@canonical.com> Date: Tue, 06 Feb 2018 20:26:23 -0500 In-Reply-To: <20180206142157.32001-1-colin.king@canonical.com> (Colin King's message of "Tue, 6 Feb 2018 14:21:57 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8797 signatures=668663 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=603 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1802070013 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin, > Pointer disc is being intializated a value that is never read and then > re-assigned the same value later on, hence the initialization is redundant > and can be removed. Applied to 4.17/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering