From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752162AbcHLBTE (ORCPT ); Thu, 11 Aug 2016 21:19:04 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:36023 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751264AbcHLBTD (ORCPT ); Thu, 11 Aug 2016 21:19:03 -0400 To: Tom Yan Cc: "Martin K. Petersen" , Shaun Tancheff , Shaun Tancheff , linux-ide@vger.kernel.org, LKML , Christoph Hellwig , Tejun Heo , Josh Bingaman Subject: Re: [PATCH v5 2/2] Add support for SCT Write Same From: "Martin K. Petersen" Organization: Oracle Corporation References: <1470790829-3793-1-git-send-email-shaun@tancheff.com> <1470790829-3793-3-git-send-email-shaun@tancheff.com> Date: Thu, 11 Aug 2016 21:18:47 -0400 In-Reply-To: (Tom Yan's message of "Thu, 11 Aug 2016 16:46:31 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Tom" == Tom Yan writes: >> Many drives from different vendors were affected by this. So we'd >> have to make multi block payloads an explicit opt-in like we did for >> discard_zeroes_data. However, given that "big" discards are mainly >> done synchronously when creating filesystems, I am not sure there is >> any real benefit to this. Tom> Probably. Perhaps it could make a difference upon deletion of some Tom> really big files (though the logical sectors used may not be Tom> continuous anyway). Nope. And you've got the bio size limit getting in the way as well. -- Martin K. Petersen Oracle Linux Engineering