From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752409AbcAFU3R (ORCPT ); Wed, 6 Jan 2016 15:29:17 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:45397 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752041AbcAFU3O (ORCPT ); Wed, 6 Jan 2016 15:29:14 -0500 To: Colin King Cc: James Bottomley , "Martin K . Petersen" , Tomas Henzl , Johannes Thumshirn , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: mvsas: fix indenting on return error code From: "Martin K. Petersen" Organization: Oracle Corporation References: <1451995000-9210-1-git-send-email-colin.king@canonical.com> Date: Wed, 06 Jan 2016 15:29:03 -0500 In-Reply-To: <1451995000-9210-1-git-send-email-colin.king@canonical.com> (Colin King's message of "Tue, 5 Jan 2016 11:56:40 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Colin" == Colin King writes: Colin, Colin> The return code and error return is incorrectly indented which Colin> may cause some confusion as it appears at first sight to be Colin> associated with a device not ready error (with missing { } Colin> braces) rather than a DEV_IS_GONE() failure. This problem has already been addressed: https://git.kernel.org/cgit/linux/kernel/git/mkp/scsi.git/commit/?h=4.5/scsi-queue&id=7789cd39274c -- Martin K. Petersen Oracle Linux Engineering