From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Jinyoung Choi <j-young.choi@samsung.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"chaitanya.kulkarni@wdc.com" <chaitanya.kulkarni@wdc.com>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Subject: Re: [PATCH v3 0/4] multi-page bvec configuration for integrity payload
Date: Tue, 08 Aug 2023 21:36:41 -0400 [thread overview]
Message-ID: <yq1zg31hubf.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20230803024656epcms2p4da6defb8e1e9b050fe2fbd52cb2e9524@epcms2p4> (Jinyoung Choi's message of "Thu, 03 Aug 2023 11:46:56 +0900")
Jinyoung,
> In the case of NVMe, it has an integrity payload consisting of one
> segment. So, rather than configuring SG_LIST, it was changed by direct
> DMA mapping.
>
> The page-merge is not performed for the struct bio_vec when creating a
> integrity payload in block. As a result, when creating an integrity
> paylaod beyond one page, each struct bio_vec is generated, and its
> bv_len does not exceed the PAGESIZE.
>
> To solve it, bio_integrity_add_page() should just add to the existing
> bvec, similar to bio_add_page() and friends.
This looks OK to me. I'll test on physical SCSI hardware tomorrow to
make sure there are no regressions.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2023-08-09 1:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230803024656epcms2p4da6defb8e1e9b050fe2fbd52cb2e9524@epcms2p4>
2023-08-03 2:46 ` Jinyoung Choi
[not found] ` <CGME20230803024656epcms2p4da6defb8e1e9b050fe2fbd52cb2e9524@epcms2p3>
2023-08-03 2:49 ` [PATCH v3 2/4] bio-integrity: update the payload size in bio_integrity_add_page() Jinyoung Choi
[not found] ` <CGME20230803024656epcms2p4da6defb8e1e9b050fe2fbd52cb2e9524@epcms2p5>
2023-08-03 2:50 ` [PATCH v3 3/4] bio-integrity: cleanup adding integrity pages to bip's bvec Jinyoung Choi
[not found] ` <CGME20230803024656epcms2p4da6defb8e1e9b050fe2fbd52cb2e9524@epcms2p8>
2023-08-03 2:48 ` [PATCH v3 1/4] block: make bvec_try_merge_hw_page() non-static Jinyoung Choi
2023-08-03 2:52 ` [PATCH v3 4/4] bio-integrity: create multi-page bvecs in bio_integrity_add_page() Jinyoung Choi
2023-08-10 2:06 ` RE:(2) [PATCH v3 0/4] multi-page bvec configuration for integrity payload Jinyoung Choi
2023-08-09 1:36 ` Martin K. Petersen [this message]
2023-08-09 22:04 ` Martin K. Petersen
2023-08-10 13:20 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1zg31hubf.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=chaitanya.kulkarni@wdc.com \
--cc=hch@infradead.org \
--cc=j-young.choi@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®