From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48D22C4361B for ; Tue, 8 Dec 2020 01:33:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF7C4221FD for ; Tue, 8 Dec 2020 01:33:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727080AbgLHBcu (ORCPT ); Mon, 7 Dec 2020 20:32:50 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:50040 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726903AbgLHBct (ORCPT ); Mon, 7 Dec 2020 20:32:49 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0B81U6au131767; Tue, 8 Dec 2020 01:31:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : message-id : references : date : in-reply-to : mime-version : content-type; s=corp-2020-01-29; bh=yzpfJ1Xeh0sADnC62vzAkdfxWP1iVP7rZGF72OFpdcY=; b=jACY7xuhGn6rLET/Vlwp5WflYFPcBRq43mL2Fhj55FDqDZ7M/QehjjZkzEKvruKwOARF H9ayO9i+GlSJjD9o9LSKLHDn4oKqknYPDhjESAZUl1prFAbSzgFxXQasIkizrfD9BPuF ewaQJqRiXRxjf00xI4rUOQ7FvEV3ooXzFhsPZlmsiNafOC60L8Rbr6cFB7GHJfqN+8Zt Dott1QwhPfaA7RQKjQm9cg+sGgDwnbxPzy0SgaZX1y3uMn06FSjv+G3GHnSxHbHq5UgF MdaVRUK9JdkhqoGnR0EkO13NHiEAsaU5ch3aeeYIUW8Na4bC6O+Y51+2Ni9IbK7MuIKx 6w== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 3581mqrcga-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 08 Dec 2020 01:31:51 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0B81Uc8h122968; Tue, 8 Dec 2020 01:31:51 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3020.oracle.com with ESMTP id 358kys4cxh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 08 Dec 2020 01:31:50 +0000 Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0B81Vmcl016786; Tue, 8 Dec 2020 01:31:48 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 07 Dec 2020 17:31:47 -0800 To: Zhang Changzhong Cc: Satish Kharat , Sesidhar Baddela , Karan Tilak Kumar , "James E.J. Bottomley" , "Martin K. Petersen" , James Bottomley , Mike Christie , Joe Eykholt , Abhijeet Joglekar , , Subject: Re: [PATCH] scsi: fnic: fix error return code in fnic_probe() From: "Martin K. Petersen" Organization: Oracle Corporation Message-ID: References: <1607068060-31203-1-git-send-email-zhangchangzhong@huawei.com> Date: Mon, 07 Dec 2020 20:31:45 -0500 In-Reply-To: <1607068060-31203-1-git-send-email-zhangchangzhong@huawei.com> (Zhang Changzhong's message of "Fri, 4 Dec 2020 15:47:39 +0800") MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9828 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 spamscore=0 mlxscore=0 malwarescore=0 suspectscore=1 mlxlogscore=999 bulkscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012080006 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9828 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 mlxlogscore=999 clxscore=1011 malwarescore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 impostorscore=0 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012080006 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Zhang, > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering