From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8107C433FF for ; Tue, 30 Jul 2019 16:21:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8413320657 for ; Tue, 30 Jul 2019 16:21:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="nP2XT//3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731087AbfG3QVw (ORCPT ); Tue, 30 Jul 2019 12:21:52 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:32922 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725793AbfG3QVw (ORCPT ); Tue, 30 Jul 2019 12:21:52 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x6UGIoR3095090; Tue, 30 Jul 2019 16:21:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=Im438v/liVUtv0Vy35qiQ6oHbLypXeSwZq7MGHu16y0=; b=nP2XT//3ff+uNn9RqB83Jc0LMcnwTt1QiX8Gs9mUn2Hj4n1QItYeHYYKff+QngytD8A7 M04sH9gw0aqmplhQ9UoABovZjb95movqv0W28M6ixk3ejYvCsVq8l21nKEBmadE6KgjY jmWPch+P85YGED/B57JK+yihPBofvv/y5yjafePG9AA9+pgEo1Z/bqXVjcwwOMOoHe0A eYQ997dzmtYorAxXPv8j58r88iHOYVX+I7SNxtMdakSae5ccG/5xIO7iyu3o97RJmSSA RhOap6lS8+nE9MLU897LiiCOlmLzlZhEEOLs6QwUpt3U1yT67nz10PwdsypwXOmFzJtS sg== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 2u0ejpfky8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 30 Jul 2019 16:21:47 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x6UGHZtu104890; Tue, 30 Jul 2019 16:21:47 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3020.oracle.com with ESMTP id 2u2jp45dm6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 30 Jul 2019 16:21:47 +0000 Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x6UGLk7Z012976; Tue, 30 Jul 2019 16:21:46 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 30 Jul 2019 09:21:46 -0700 To: Chuhong Yuan Cc: qla2xxx-upstream@qlogic.com, "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] scsi: qla2xxx: Replace vmalloc + memset with vzalloc From: "Martin K. Petersen" Organization: Oracle Corporation References: <20190718074518.16273-1-hslester96@gmail.com> Date: Tue, 30 Jul 2019 12:21:44 -0400 In-Reply-To: <20190718074518.16273-1-hslester96@gmail.com> (Chuhong Yuan's message of "Thu, 18 Jul 2019 15:45:18 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9334 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=730 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1907300169 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9334 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=798 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1907300169 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Chuhong, > Use vzalloc instead of using vmalloc to allocate memory and then > zeroing it with memset. This simplifies the code. Applied to 5.4/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering