From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: <jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
<bvanassche@acm.org>, <axboe@kernel.dk>, <hare@suse.de>,
<linux-kernel@vger.kernel.org>, <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] scsi: scsi_dh_alua: Fix possible null-ptr-deref
Date: Wed, 29 May 2019 22:04:57 -0400 [thread overview]
Message-ID: <yq1zhn4y9x2.fsf@oracle.com> (raw)
In-Reply-To: <20190527142209.21768-1-yuehaibing@huawei.com> (yuehaibing@huawei.com's message of "Mon, 27 May 2019 22:22:09 +0800")
YueHaibing,
> If alloc_workqueue fails in alua_init, it should return -ENOMEM,
> otherwise it will trigger null-ptr-deref while unloading module which
> calls destroy_workqueue dereference wq->lock like this:
Applied to 5.2/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2019-05-30 2:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-27 14:22 YueHaibing
2019-05-27 15:08 ` Bart Van Assche
2019-05-30 2:04 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1zhn4y9x2.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome