From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Boaz Harrosh <ooo@electrozaur.com>,
Benny Halevy <bhalevy@primarydata.com>,
"James E.J. Bottomley" <JBottomley@odin.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
osd-dev@open-osd.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [SCSI] osd: fix signed char versus %02x issue
Date: Thu, 10 Dec 2015 13:15:39 -0500 [thread overview]
Message-ID: <yq1zixi186s.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <1449584716-21093-1-git-send-email-linux@rasmusvillemoes.dk> (Rasmus Villemoes's message of "Tue, 8 Dec 2015 15:25:16 +0100")
>>>>> "Rasmus" == Rasmus Villemoes <linux@rasmusvillemoes.dk> writes:
Rasmus> If char is signed and one of these bytes happen to have a value
Rasmus> outside the ascii range, the corresponding output will consist
Rasmus> of "ffffff" followed by the two hex chars that were actually
Rasmus> intended. One way to fix it would be to change the casts to
Rasmus> (u8*) aka (unsigned char*), but it is much simpler (and
Rasmus> generates smaller code) to use the %ph extension which was
Rasmus> created for such short hexdumps.
Applied to 4.5/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2015-12-10 18:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 14:25 Rasmus Villemoes
2015-12-08 22:21 ` Boaz Harrosh
2015-12-10 18:15 ` Martin K. Petersen [this message]
2015-12-10 19:10 ` Andy Shevchenko
2015-12-10 19:13 ` Martin K. Petersen
2015-12-10 19:25 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1zixi186s.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=JBottomley@odin.com \
--cc=bhalevy@primarydata.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=ooo@electrozaur.com \
--cc=osd-dev@open-osd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®