From: Aneesh Kumar K.V <aneesh.kumar@kernel.org>
To: Xu Yilun <yilun.xu@linux.intel.com>,
jgg@nvidia.com, jgg@ziepe.ca, kevin.tian@intel.com,
will@kernel.org
Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
joro@8bytes.org, robin.murphy@arm.com, shuah@kernel.org,
nicolinc@nvidia.com, aik@amd.com, dan.j.williams@intel.com,
baolu.lu@linux.intel.com, yilun.xu@intel.com
Subject: Re: [PATCH v6 0/8] iommufd: Destroy vdevice on device unbind
Date: Fri, 18 Jul 2025 14:43:35 +0530 [thread overview]
Message-ID: <yq5ajz45275s.fsf@kernel.org> (raw)
In-Reply-To: <20250716070349.1807226-1-yilun.xu@linux.intel.com>
Xu Yilun <yilun.xu@linux.intel.com> writes:
> It is to solve the lifecycle issue that vdevice may outlive idevice. It
> is a prerequisite for TIO, to ensure extra secure configurations (e.g.
> TSM Bind/Unbind) against vdevice could be rolled back on idevice unbind,
> so that VFIO could still work on the physical device without surprise.
>
> Changelog:
> v6:
> - Fix compile error for ARM platform in Patch 5
> - Adjust some more line wrappings in Patch 6
> - Add review tags.
>
> v5: https://lore.kernel.org/linux-iommu/aHdFWV9k9M7tRpD0@yilunxu-OptiPlex-7050/
> - Further rebase to iommufd for-next 601b1d0d9395
> - Keep the xa_empty() check in iommufd_fops_release(), update comments
> - Move the *idev next to *viommu for struct iommufd_vdevice
> - Update the description about IOMMUFD_CMD_VDEVICE_ALLOC for lifecycle
> - Remove Baolu's tag for patch 4 because of big changes since v3
> - Add changelog about idev->destroying
> - Adjust line wrappings for tools/testing/selftests/iommu/iommufd.c
> - Clarify that no testing for tombstoned ID repurposing.
> - Add review tags.
>
> v4: https://lore.kernel.org/linux-iommu/20250709040234.1773573-1-yilun.xu@linux.intel.com/
> - Rebase to iommufd for-next.
> - A new patch to roll back iommufd_object_alloc_ucmd() for vdevice.
> - Fix the mistake trying to xa_destroy ictx->groups on
> iommufd_fops_release().
> - Move 'empty' flag inside destroy loop for iommufd_fops_release().
> - Refactor vdev/idev destroy syncing.
> - Drop the iommufd_vdevice_abort() reentrant idea.
> - A new patch that adds pre_destroy() op.
> - Hold short term reference during the whole vdevice's lifecycle.
> - Wait on short term reference on idev's pre_destroy().
> - Add a 'destroying' flag for idev to prevent new reference after
> pre_destroy().
> - Rephrase/fix some comments.
> - Add review tags.
>
> v3: https://lore.kernel.org/linux-iommu/20250627033809.1730752-1-yilun.xu@linux.intel.com/
> - No bother clean each tombstone in iommufd_fops_release().
> - Drop vdev->ictx initialization fix patch.
> - Optimize control flow in iommufd_device_remove_vdev().
> - Make iommufd_vdevice_abort() reentrant.
> - Call iommufd_vdevice_abort() directly instead of waiting for it.
> - Rephrase/fix some comments.
> - A new patch to remove vdev->dev.
> - A new patch to explicitly skip existing viommu tests for no_iommu.
> - Also skip vdevice tombstone test for no_iommu.
> - Allow me to add SoB from Aneesh.
>
> v2: https://lore.kernel.org/linux-iommu/20250623094946.1714996-1-yilun.xu@linux.intel.com/
>
> v1/rfc: https://lore.kernel.org/linux-iommu/20250610065146.1321816-1-aneesh.kumar@kernel.org/
>
> The series is based on iommufd for-next
>
>
> Xu Yilun (8):
> iommufd/viommu: Roll back to use iommufd_object_alloc() for vdevice
> iommufd: Add iommufd_object_tombstone_user() helper
> iommufd: Add a pre_destroy() op for objects
> iommufd: Destroy vdevice on idevice destroy
> iommufd/vdevice: Remove struct device reference from struct vdevice
> iommufd/selftest: Explicitly skip tests for inapplicable variant
> iommufd/selftest: Add coverage for vdevice tombstone
> iommufd: Rename some shortterm-related identifiers
>
> .../iommu/arm/arm-smmu-v3/tegra241-cmdqv.c | 3 +-
> drivers/iommu/iommufd/device.c | 51 +++
> drivers/iommu/iommufd/driver.c | 10 +-
> drivers/iommu/iommufd/iommufd_private.h | 49 ++-
> drivers/iommu/iommufd/main.c | 69 +++-
> drivers/iommu/iommufd/viommu.c | 69 +++-
> include/linux/iommufd.h | 17 +-
> include/uapi/linux/iommufd.h | 5 +
> tools/testing/selftests/iommu/iommufd.c | 377 +++++++++---------
> 9 files changed, 419 insertions(+), 231 deletions(-)
>
Can you share the commit id these patches are against.
-aneesh
next prev parent reply other threads:[~2025-07-18 9:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 7:03 Xu Yilun
2025-07-16 7:03 ` [PATCH v6 1/8] iommufd/viommu: Roll back to use iommufd_object_alloc() for vdevice Xu Yilun
2025-07-16 7:03 ` [PATCH v6 2/8] iommufd: Add iommufd_object_tombstone_user() helper Xu Yilun
2025-07-16 7:03 ` [PATCH v6 3/8] iommufd: Add a pre_destroy() op for objects Xu Yilun
2025-07-16 7:03 ` [PATCH v6 4/8] iommufd: Destroy vdevice on idevice destroy Xu Yilun
2025-07-16 7:03 ` [PATCH v6 5/8] iommufd/vdevice: Remove struct device reference from struct vdevice Xu Yilun
2025-07-16 7:03 ` [PATCH v6 6/8] iommufd/selftest: Explicitly skip tests for inapplicable variant Xu Yilun
2025-07-16 7:03 ` [PATCH v6 7/8] iommufd/selftest: Add coverage for vdevice tombstone Xu Yilun
2025-07-16 7:03 ` [PATCH v6 8/8] iommufd: Rename some shortterm-related identifiers Xu Yilun
2025-07-18 9:13 ` Aneesh Kumar K.V [this message]
2025-07-19 15:33 ` [PATCH v6 0/8] iommufd: Destroy vdevice on device unbind Xu Yilun
2025-07-18 17:30 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq5ajz45275s.fsf@kernel.org \
--to=aneesh.kumar@kernel.org \
--cc=aik@amd.com \
--cc=baolu.lu@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=shuah@kernel.org \
--cc=will@kernel.org \
--cc=yilun.xu@intel.com \
--cc=yilun.xu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome