Re: [PATCH] Add CRC32C chksums to crypto routines

[Clay Haapala <chaapala@cisco.com>]

On Mon, 19 Jan 2004, James Morris stated:
> On Wed, 14 Jan 2004, Clay Haapala wrote:
> 
>> This patch against 2.6.1 adds CRC32C checksumming capabilities to
>> the crypto routines.  The structure of it is based wholly on the
>> existing digest (md5) routines, the main difference being that
>> chksums are often used in an "accumulator" fashion, effectively
>> requiring one to set the seed, and the digest algorithms don't do
>> that.
> 
> Looks good to me.
> 
In other email, Matt Mackall suggested a slightly different
integration with the kernel that would allow more general usage of the
CRC32C.  His suggestion was to put the implementation under /lib, next
to the crc32 routines, and make the crypto routine a wrapper that calls
it.  Selecting the CRYPTO_CRC32C module would SELECT the lib CRC32C
module, in other words.

The benefit of this would be to allow easy usage by other routines
(with no premption side-affects, a concern Matt has) while still being
there for routines that process scatterlist.  And the table/code is
still in one place.

Patch to follow in a day or two, after I can test it.  Implementation
was simple.
-- 
Clay Haapala (chaapala@cisco.com) Cisco Systems SRBU +1 763-398-1056
   6450 Wedgwood Rd, Suite 130 Maple Grove MN 55311 PGP: C89240AD
	 Funny, I didn't think Haliburton was into aerospace.