From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACC66C10F29 for ; Tue, 17 Mar 2020 08:28:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 88CF520767 for ; Tue, 17 Mar 2020 08:28:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726277AbgCQI2c (ORCPT ); Tue, 17 Mar 2020 04:28:32 -0400 Received: from mga06.intel.com ([134.134.136.31]:15232 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725868AbgCQI2b (ORCPT ); Tue, 17 Mar 2020 04:28:31 -0400 IronPort-SDR: L+wOpw7Il/Ya190YYDNNlQMOn7UllIZCQ8dXXTUlYPe3aOJvRLEPp+nCvVvfVW8o1pDmZk+WWu 1O6JNQhljKXA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2020 01:28:31 -0700 IronPort-SDR: healM5eFWf/Kw6gBx4FVqQaJZugrClmjQKDXhbzYDs3BBjEOxoAnAMbVR9ke5InzTm6fiaOhDa EEpQ9MKjRDYw== X-IronPort-AV: E=Sophos;i="5.70,563,1574150400"; d="scan'208";a="390985809" Received: from bquerbac-mobl1.amr.corp.intel.com (HELO localhost) ([10.135.40.52]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2020 01:28:28 -0700 From: "Patrick Ohly" To: Vivek Goyal Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org, virtio-fs@redhat.com, miklos@szeredi.hu, stefanha@redhat.com, dgilbert@redhat.com, mst@redhat.com Subject: Re: [PATCH 00/20] virtiofs: Add DAX support In-Reply-To: <20200316130234.GA4013@redhat.com> Organization: Intel GmbH, Dornacher Strasse 1, D-85622 Feldkirchen/Munich References: <20200304165845.3081-1-vgoyal@redhat.com> <20200316130234.GA4013@redhat.com> Date: Tue, 17 Mar 2020 09:28:26 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Vivek Goyal writes: > We expect users will issue fsync/msync like a regular filesystem to > make changes persistent. So in that aspect, rejecting MAP_SYNC > makes sense. I will test and see if current code is rejecting MAP_SYNC > or not. Last time I checked, it did. Here's the test program that I wrote for that: https://github.com/intel/pmem-csi/blob/ee3200794a1ade49a02df6f359a134115b409e90/test/cmd/pmem-dax-check/main.go -- Best Regards Patrick Ohly