From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753702AbcBENjY (ORCPT <rfc822;w@1wt.eu>);
	Fri, 5 Feb 2016 08:39:24 -0500
Received: from unicorn.mansr.com ([81.2.72.234]:53292 "EHLO unicorn.mansr.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751672AbcBENjW convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 5 Feb 2016 08:39:22 -0500
From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= <mans@mansr.com>
To: Sebastian Frias <sf84@laposte.net>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>, mason <slash.tmp@free.fr>
Subject: Re: [PATCH] net: ethernet: support "fixed-link" DT node on nb8800 driver
References: <56B4A445.7080402@laposte.net>
Date: Fri, 05 Feb 2016 13:39:20 +0000
In-Reply-To: <56B4A445.7080402@laposte.net> (Sebastian Frias's message of
	"Fri, 05 Feb 2016 14:31:49 +0100")
Message-ID: <yw1x1t8ri8dz.fsf@unicorn.mansr.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Sebastian Frias <sf84@laposte.net> writes:

> Signed-off-by: Sebastian Frias <sf84@laposte.net>
> ---
>  drivers/net/ethernet/aurora/nb8800.c | 19 +++++++++++++++----
>  1 file changed, 15 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/aurora/nb8800.c
> b/drivers/net/ethernet/aurora/nb8800.c
> index ecc4a33..1353fee 100644
> --- a/drivers/net/ethernet/aurora/nb8800.c
> +++ b/drivers/net/ethernet/aurora/nb8800.c
> @@ -1461,10 +1461,21 @@ static int nb8800_probe(struct platform_device
> *pdev)
>  	}
>
>  	priv->phy_node = of_parse_phandle(pdev->dev.of_node, "phy-handle", 0);
> -	if (!priv->phy_node) {
> -		dev_err(&pdev->dev, "no PHY specified\n");
> -		ret = -ENODEV;
> -		goto err_free_bus;
> +	if (!priv->phy_node)
> +	{
> +		if (of_phy_is_fixed_link(pdev->dev.of_node)) {
> +			ret = of_phy_register_fixed_link(pdev->dev.of_node);
> +			if (ret < 0) {
> +				dev_err(&pdev->dev, "broken fixed-link specification\n");

Line is longer than 80 chars.

> +				goto err_free_bus;
> +			}
> +			priv->phy_node = of_node_get(pdev->dev.of_node);
> +		}
> +		else {

Wrong brace placement.

> +			dev_err(&pdev->dev, "no PHY specified\n");
> +			ret = -ENODEV;
> +			goto err_free_bus;
> +		}
>  	}
>
>  	priv->mii_bus = bus;
> -- 
> 2.1.4
>

-- 
Måns Rullgård