From: "Måns Rullgård" <mru@inprovide.com>
To: Hugh Dickins <hugh@veritas.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: shmem_file_setup not exported
Date: Sat, 06 Nov 2004 20:56:40 +0100 [thread overview]
Message-ID: <yw1x1xf6oio7.fsf@ford.inprovide.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0411061937370.4000-100000@localhost.localdomain> (Hugh Dickins's message of "Sat, 6 Nov 2004 19:42:55 +0000 (GMT)")
Hugh Dickins <hugh@veritas.com> writes:
> On Sat, 6 Nov 2004, Måns Rullgård wrote:
>> I noticed this change in mm/shmem.c:
>>
>> -EXPORT_SYMBOL(shmem_file_setup);
>>
>> Is there a reason for this, other than nobody using it?
>
> That's the reason hch rightly removed the export, yes.
> ipc/shm.c does use it, but it's never a module, so doesn't need export.
> No other reason, beyond that it's appropriate to minimize exports.
> If you want to use it from your module, just patch the export back.
That makes using the module more complicated. I don't really care
much, I'm not actively using the module. I was just wondering whether
using it was incredibly silly for some reason.
--
Måns Rullgård
mru@inprovide.com
prev parent reply other threads:[~2004-11-06 19:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-06 19:31 Måns Rullgård
2004-11-06 19:42 ` Hugh Dickins
2004-11-06 19:56 ` Måns Rullgård [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yw1x1xf6oio7.fsf@ford.inprovide.com \
--to=mru@inprovide.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®