From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2550EC433DF for ; Tue, 14 Jul 2020 13:40:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB4B422470 for ; Tue, 14 Jul 2020 13:40:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726795AbgGNNkf convert rfc822-to-8bit (ORCPT ); Tue, 14 Jul 2020 09:40:35 -0400 Received: from unicorn.mansr.com ([81.2.72.234]:48628 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725906AbgGNNkf (ORCPT ); Tue, 14 Jul 2020 09:40:35 -0400 Received: by unicorn.mansr.com (Postfix, from userid 65534) id 0337015360; Tue, 14 Jul 2020 14:40:32 +0100 (BST) Received: from raven.mansr.com (raven.mansr.com [IPv6:2001:8b0:ca0d:8d8e::3]) by unicorn.mansr.com (Postfix) with ESMTPS id 42A1F15360; Tue, 14 Jul 2020 14:40:32 +0100 (BST) Received: by raven.mansr.com (Postfix, from userid 51770) id 392E321A6F3; Tue, 14 Jul 2020 14:40:32 +0100 (BST) From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Chen-Yu Tsai Cc: Maxime Ripard , David Airlie , Daniel Vetter , Chen-Yu Tsai , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: sun4i: hdmi: Fix inverted HPD result References: <20200711011030.21997-1-wens@kernel.org> Date: Tue, 14 Jul 2020 14:40:32 +0100 In-Reply-To: <20200711011030.21997-1-wens@kernel.org> (Chen-Yu Tsai's message of "Sat, 11 Jul 2020 09:10:30 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Chen-Yu Tsai writes: > From: Chen-Yu Tsai > > When the extra HPD polling in sun4i_hdmi was removed, the result of > HPD was accidentally inverted. > > Fix this by inverting the check. > > Fixes: bda8eaa6dee7 ("drm: sun4i: hdmi: Remove extra HPD polling") > Signed-off-by: Chen-Yu Tsai Tested-by: Mans Rullgard > --- > > Sorry for the screw-up. > > --- > drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c > index 557cbe5ab35f..2f2c9f0a1071 100644 > --- a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c > +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c > @@ -260,7 +260,7 @@ sun4i_hdmi_connector_detect(struct drm_connector *connector, bool force) > unsigned long reg; > > reg = readl(hdmi->base + SUN4I_HDMI_HPD_REG); > - if (reg & SUN4I_HDMI_HPD_HIGH) { > + if (!(reg & SUN4I_HDMI_HPD_HIGH)) { > cec_phys_addr_invalidate(hdmi->cec_adap); > return connector_status_disconnected; > } > -- > 2.27.0 > -- Måns Rullgård