From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753867AbcBENXb (ORCPT ); Fri, 5 Feb 2016 08:23:31 -0500 Received: from unicorn.mansr.com ([81.2.72.234]:53188 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753833AbcBENXX convert rfc822-to-8bit (ORCPT ); Fri, 5 Feb 2016 08:23:23 -0500 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Mark Brown Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: mxs-saif: check BUSY bit in hw_params() only if not mclk_in_use References: <1454505500-30384-1-git-send-email-mans@mansr.com> <20160205131944.GB12311@sirena.org.uk> Date: Fri, 05 Feb 2016 13:23:20 +0000 In-Reply-To: <20160205131944.GB12311@sirena.org.uk> (Mark Brown's message of "Fri, 5 Feb 2016 13:19:44 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mark Brown writes: > On Wed, Feb 03, 2016 at 01:18:20PM +0000, Mans Rullgard wrote: >> If something else, typically a codec, has enabled mclk, the BUSY >> bit may be set when hw_params() is called without this being an >> error. This check thus causes intermittent failures to configure >> the sound device when used in such a manner. Fix this by making >> the test conditional on !saif->mclk_in_use. > > Please remember to CC the maintainers for the driver when sending > patches. I CCd everybody scripts/get_maintainers.pl suggested. How am I supposed to know who the maintainers are if they're not listed in MAINTAINERS? -- Måns Rullgård