From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755301AbcBEP6v (ORCPT <rfc822;w@1wt.eu>);
	Fri, 5 Feb 2016 10:58:51 -0500
Received: from unicorn.mansr.com ([81.2.72.234]:53712 "EHLO unicorn.mansr.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755271AbcBEP6u convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 5 Feb 2016 10:58:50 -0500
From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= <mans@mansr.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Sebastian Frias <sf84@laposte.net>,
        "David S. Miller" <davem@davemloft.net>,
        netdev <netdev@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        mason <slash.tmp@free.fr>
Subject: Re: [PATCH] net: ethernet: support "fixed-link" DT node on nb8800 driver
References: <56B4A445.7080402@laposte.net>
	<yw1x1t8ri8dz.fsf@unicorn.mansr.com>
	<CAHp75Vc0nW5EuLD7-ZmB5e63vvFLdmjfbd4a1nAweeTGOs795Q@mail.gmail.com>
Date: Fri, 05 Feb 2016 15:58:42 +0000
In-Reply-To: <CAHp75Vc0nW5EuLD7-ZmB5e63vvFLdmjfbd4a1nAweeTGOs795Q@mail.gmail.com>
	(Andy Shevchenko's message of "Fri, 5 Feb 2016 17:57:56 +0200")
Message-ID: <yw1x7fijgnd9.fsf@unicorn.mansr.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Andy Shevchenko <andy.shevchenko@gmail.com> writes:

> On Fri, Feb 5, 2016 at 3:39 PM, Måns Rullgård <mans@mansr.com> wrote:
>>> +                     if (ret < 0) {
>>> +                             dev_err(&pdev->dev, "broken fixed-link specification\n");
>>
>> Line is longer than 80 chars.
>
> This is actually okay, though I would recommend to move long string
> literal to the next line.

I only mentioned it because fixing it was trivial.

-- 
Måns Rullgård