From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932848AbcAKMyS (ORCPT <rfc822;w@1wt.eu>);
	Mon, 11 Jan 2016 07:54:18 -0500
Received: from unicorn.mansr.com ([81.2.72.234]:55418 "EHLO unicorn.mansr.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932806AbcAKMyP (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 11 Jan 2016 07:54:15 -0500
From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= <mans@mansr.com>
To: "Shevchenko\, Andriy" <andriy.shevchenko@intel.com>
Cc: "gregkh\@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "anton.wuerfel\@fau.de" <anton.wuerfel@fau.de>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "mail\@maciej.szmigiero.name" <mail@maciej.szmigiero.name>,
        "desmondl\@broadcom.com" <desmondl@broadcom.com>,
        "Zha\, Qipeng" <qipeng.zha@intel.com>,
        "heikki.krogerus\@linux.intel.com" <heikki.krogerus@linux.intel.com>,
        "long.wanglong\@huawei.com" <long.wanglong@huawei.com>,
        "soeren.grunewald\@desy.de" <soeren.grunewald@desy.de>,
        "deller\@gmx.de" <deller@gmx.de>, "jslaby\@suse.com" <jslaby@suse.com>,
        "phillip.raffeck\@fau.de" <phillip.raffeck@fau.de>,
        "paul.burton\@imgtec.com" <paul.burton@imgtec.com>,
        "hpeter\@gmail.com" <hpeter@gmail.com>,
        "ralf\@linux-mips.org" <ralf@linux-mips.org>,
        "linux-kernel\@i4.cs.fau.de" <linux-kernel@i4.cs.fau.de>,
        "adam.lee\@canonical.com" <adam.lee@canonical.com>,
        "jejb\@parisc-linux.org" <jejb@parisc-linux.org>,
        "linux-parisc\@vger.kernel.org" <linux-parisc@vger.kernel.org>,
        "peter\@hurleysoftware.com" <peter@hurleysoftware.com>,
        "matt.redfearn\@imgtec.com" <matt.redfearn@imgtec.com>,
        "k.kozlowski\@samsung.com" <k.kozlowski@samsung.com>
Subject: Re: [PATCH v4 01/13] tty: serial: 8250: Fix whitespace errors
References: <1452275039-18787-1-git-send-email-anton.wuerfel@fau.de>
	<1452275039-18787-2-git-send-email-anton.wuerfel@fau.de>
	<1452515294.26146.10.camel@linux.intel.com>
	<1452516646.26146.22.camel@intel.com>
Date: Mon, 11 Jan 2016 12:54:10 +0000
In-Reply-To: <1452516646.26146.22.camel@intel.com> (Andriy Shevchenko's
	message of "Mon, 11 Jan 2016 12:50:18 +0000")
Message-ID: <yw1x7fjgxonh.fsf@unicorn.mansr.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

"Shevchenko, Andriy" <andriy.shevchenko@intel.com> writes:

> On Mon, 2016-01-11 at 14:28 +0200, Andy Shevchenko wrote:
>> On Fri, 2016-01-08 at 18:43 +0100, Anton Wuerfel wrote:
>> > This patch fixes whitespace errors reported by checkpatch to
>> > increase
>> > readability. Main focus is on missing spaces after commas in
>> > function headers and macros (like foo,bar edited to foo, bar).
>> > 
>> > Signed-off-by: Anton Würfel <anton.wuerfel@fau.de>
>> > Signed-off-by: Phillip Raffeck <phillip.raffeck@fau.de>
>> > CC: linux-kernel@i4.cs.fau.de
>> 
>> Cc: looks more standard.
>> 
>> > --- a/drivers/tty/serial/8250/8250_accent.c
>> > +++ b/drivers/tty/serial/8250/8250_accent.c
>> > @@ -10,7 +10,7 @@
>> >  #include <linux/init.h>
>> >  #include <linux/serial_8250.h>
>> >  
>> > -#define PORT(_base,_irq)				\
>> > +#define PORT(_base, _irq)				\
>> >  	{						\
>> >  		.iobase		= _base,		\
>> >  		.irq		= _irq,			
>> > \
>
> 8250_PORT()
>
>> > 
>> 
>> While those are okay, I would suggest to make a macro in
>> drivers/…/8250.h one for all, something like this:
>> 
>> #define 8250_PORT_FLAGS(_base, _irq, _flags)
>> …
>> 	.flags          = UPF_BOOT_AUTOCONF | (_flags) \
>> 
>> #define 8250_PORT(_base, _irq)	8250_PORT_FLAGS(_base, _irq, 0)
>> 
>> And use it.
>
> #define 8250_FOURPORT(_base, _irq)	8250_PORT_FLAGS(_base, _irq,
> UPF_FOURPORT)

Macro names can't start with a number.

-- 
Måns Rullgård