From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753659AbbLQSwD (ORCPT ); Thu, 17 Dec 2015 13:52:03 -0500 Received: from unicorn.mansr.com ([81.2.72.234]:46460 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751552AbbLQSwA convert rfc822-to-8bit (ORCPT ); Thu, 17 Dec 2015 13:52:00 -0500 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Julian Margetson Cc: Andy Shevchenko , Tejun Heo , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel References: <1450221935-6034-1-git-send-email-mans@mansr.com> <1450364395.30729.136.camel@linux.intel.com> <1450367702.30729.146.camel@linux.intel.com> <1450371184.30729.175.camel@linux.intel.com> <5672F77F.4010306@candw.ms> <567302E8.5050303@candw.ms> Date: Thu, 17 Dec 2015 18:51:57 +0000 In-Reply-To: <567302E8.5050303@candw.ms> (Julian Margetson's message of "Thu, 17 Dec 2015 14:46:00 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Julian Margetson writes: > On 12/17/2015 1:59 PM, Måns Rullgård wrote: >> Julian Margetson writes: >> >>> I have been running my machine mostly configured for pciex1 thus with >>> the sata_dwc disabled. >>> The changes to sata_dwc-460ex do cause an oops. >>> I will try to give more detailed info over this weekend . >> The driver as is upstream would do that since it unconditionally >> dereferences a null pointer in the probe function. My patch fixes that >> as a side-effect. >> > > patching file drivers/ata/Kconfig > > Hunk #1 FAILED at 296. [...] > root@julian-VirtualBox:/usr/src/linux-3.18.25# The patch is against 4.4-rc5. -- Måns Rullgård