From: "Måns Rullgård" <mans@mansr.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>,
Marc Zyngier <marc.zyngier@arm.com>,
Sebastian Frias <sf84@laposte.net>,
Jason Cooper <jason@lakedaemon.net>,
Arnd Bergmann <arnd@arndb.de>,
LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller
Date: Wed, 20 Jan 2016 17:05:26 +0000 [thread overview]
Message-ID: <yw1xa8o0qizt.fsf@unicorn.mansr.com> (raw)
In-Reply-To: <20160120170219.GC28169@leverpostej> (Mark Rutland's message of "Wed, 20 Jan 2016 17:02:20 +0000")
Mark Rutland <mark.rutland@arm.com> writes:
> On Wed, Jan 20, 2016 at 05:24:14PM +0100, Marc Gonzalez wrote:
>> On 20/01/2016 17:10, Måns Rullgård wrote:
>>
>> > Marc Zyngier wrote:
>> >
>> >>> + if (of_property_read_u32(node, "reg", &ctl))
>> >>> + panic("%s: failed to get reg base", node->name);
>> >>> +
>> >>> + chip = kzalloc(sizeof(*chip), GFP_KERNEL);
>> >>> + chip->ctl = ctl;
>> >>> + chip->base = base;
>> >
>> > As I said before, this assumes the outer DT node uses a ranges
>> > property. Normally reg properties work the same whether they specify an
>> > offset within an outer "ranges" or have a full address directly. It
>> > would be easy enough to make this work with either, so I don't see any
>> > reason not to.
>>
>> IIRC, I was told very early in the review process that the ranges prop
>> was mandatory. Lemme look for it... It was Arnd:
>>
>> http://thread.gmane.org/gmane.linux.ports.arm.kernel/444131/focus=444207
>
> I believe Arnd's point was that you need _a_ ranges property, rather
> than specifically requiring an idmap/empty ranges property.
>
> As Marc pointed out, you can use of_iomap on the child nodes to map the
> portions described by the reg properties, which will handle any
> ranges-based translation automatically.
No, that's going to get ugly because the generic irqchip needs a single
base address and some of the registers are shared (not part of the range
specified in the child nodes).
--
Måns Rullgård
next prev parent reply other threads:[~2016-01-20 17:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 12:56 [RFC PATCH v2] " Marc Gonzalez
2016-01-18 13:04 ` Måns Rullgård
2016-01-18 15:57 ` Marc Gonzalez
2016-01-18 16:44 ` [RFC PATCH v3] " Marc Gonzalez
2016-01-20 16:04 ` Marc Zyngier
2016-01-20 16:10 ` Måns Rullgård
2016-01-20 16:23 ` Marc Zyngier
2016-01-20 16:25 ` Måns Rullgård
2016-01-20 16:36 ` Marc Gonzalez
2016-01-20 16:38 ` Måns Rullgård
2016-01-20 16:43 ` Marc Gonzalez
2016-01-20 18:09 ` Måns Rullgård
2016-01-22 15:58 ` Marc Gonzalez
2016-01-22 16:35 ` Måns Rullgård
2016-01-22 16:37 ` Marc Gonzalez
2016-01-22 16:39 ` Måns Rullgård
2016-01-22 16:45 ` Marc Gonzalez
2016-01-22 16:49 ` Måns Rullgård
2016-01-20 16:24 ` Marc Gonzalez
2016-01-20 16:26 ` Måns Rullgård
2016-01-20 17:02 ` Mark Rutland
2016-01-20 17:05 ` Måns Rullgård [this message]
2016-01-20 17:05 ` Marc Gonzalez
2016-01-20 17:06 ` Måns Rullgård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yw1xa8o0qizt.fsf@unicorn.mansr.com \
--to=mans@mansr.com \
--cc=arnd@arndb.de \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=marc_gonzalez@sigmadesigns.com \
--cc=mark.rutland@arm.com \
--cc=sf84@laposte.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®