From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751615AbcGPLBM (ORCPT ); Sat, 16 Jul 2016 07:01:12 -0400 Received: from unicorn.mansr.com ([81.2.72.234]:37954 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751435AbcGPLBK convert rfc822-to-8bit (ORCPT ); Sat, 16 Jul 2016 07:01:10 -0400 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Florian Fainelli Cc: netdev@vger.kernel.org, davem@davemloft.net, Sebastian Frias , Arnd Bergmann , linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH net] net: nb8800: Fix SKB leak in nb8800_receive() References: <1468626084-31618-1-git-send-email-f.fainelli@gmail.com> Date: Sat, 16 Jul 2016 12:01:03 +0100 In-Reply-To: <1468626084-31618-1-git-send-email-f.fainelli@gmail.com> (Florian Fainelli's message of "Fri, 15 Jul 2016 16:41:16 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Florian Fainelli writes: > In case nb8800_receive() fails to allocate a fragment, we would leak the > SKB freshly allocated and just return, instead, free it. > > Reported-by: coverity (CID 1341750) > Signed-off-by: Florian Fainelli Acked-by: Mans Rullgard > --- > drivers/net/ethernet/aurora/nb8800.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c > index 08a23e6b60e9..1a3555d03a96 100644 > --- a/drivers/net/ethernet/aurora/nb8800.c > +++ b/drivers/net/ethernet/aurora/nb8800.c > @@ -259,6 +259,7 @@ static void nb8800_receive(struct net_device *dev, unsigned int i, > if (err) { > netdev_err(dev, "rx buffer allocation failed\n"); > dev->stats.rx_dropped++; > + dev_kfree_skb(skb); > return; > } > > -- > 2.7.4 > -- Måns Rullgård