From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932831AbcAKQQg (ORCPT ); Mon, 11 Jan 2016 11:16:36 -0500 Received: from unicorn.mansr.com ([81.2.72.234]:56105 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760042AbcAKQQf convert rfc822-to-8bit (ORCPT ); Mon, 11 Jan 2016 11:16:35 -0500 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Mark Brown Cc: linux-arm-kernel@lists.infradead.org, Cyrille Pitchen , "Yang\, Wenyou" , Nicolas Ferre , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] spi: atmel: improve internal vs gpio chip-select choice References: <1452528102-26458-1-git-send-email-mans@mansr.com> <20160111161333.GK6588@sirena.org.uk> Date: Mon, 11 Jan 2016 16:16:31 +0000 In-Reply-To: <20160111161333.GK6588@sirena.org.uk> (Mark Brown's message of "Mon, 11 Jan 2016 16:13:33 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mark Brown writes: > On Mon, Jan 11, 2016 at 04:01:42PM +0000, Mans Rullgard wrote: >> The driver currently chooses between internal chip-select or gpio >> based on the existence of the cs-gpios DT property which fails on >> non-DT systems and also enforces the same choice for all devices. > > Normally you shouldn't send incremental patches against patches that > have already been applied. Should or shouldn't? > However in this case I'm going to drop your original patch anyway due > to the issue that was found so it's OK. Sorry, I hadn't noticed it was already applied. Too many trees to keep track of. -- Måns Rullgård