From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757170AbcAJOAr (ORCPT <rfc822;w@1wt.eu>);
	Sun, 10 Jan 2016 09:00:47 -0500
Received: from unicorn.mansr.com ([81.2.72.234]:53448 "EHLO unicorn.mansr.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1756405AbcAJOAq convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 10 Jan 2016 09:00:46 -0500
From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= <mans@mansr.com>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Sascha Hauer <kernel@pengutronix.de>, Pawel Moll <pawel.moll@arm.com>,
        Russell King <linux@arm.linux.org.uk>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        Kumar Gala <galak@codeaurora.org>, Shawn Guo <shawnguo@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2
References: <1452429613-28783-1-git-send-email-mans@mansr.com>
	<1473600647.505612.cb24b396-67be-4b7b-9938-7cb30ef4fe05.open-xchange@email.1und1.de>
	<yw1xoacty3uz.fsf@unicorn.mansr.com>
	<89586980.506110.cb24b396-67be-4b7b-9938-7cb30ef4fe05.open-xchange@email.1und1.de>
	<yw1xk2nhy2j8.fsf@unicorn.mansr.com>
	<1662250621.506558.cb24b396-67be-4b7b-9938-7cb30ef4fe05.open-xchange@email.1und1.de>
Date: Sun, 10 Jan 2016 14:00:42 +0000
In-Reply-To: <1662250621.506558.cb24b396-67be-4b7b-9938-7cb30ef4fe05.open-xchange@email.1und1.de>
	(Stefan Wahren's message of "Sun, 10 Jan 2016 14:58:40 +0100 (CET)")
Message-ID: <yw1xfuy5y1o5.fsf@unicorn.mansr.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Stefan Wahren <stefan.wahren@i2se.com> writes:

>> Måns Rullgård <mans@mansr.com> hat am 10. Januar 2016 um 14:42 geschrieben:
>>
>>
>> Stefan Wahren <stefan.wahren@i2se.com> writes:
>>
>> >> Måns Rullgård <mans@mansr.com> hat am 10. Januar 2016 um 14:13 geschrieben:
>> >>
>> >>
>> >> Stefan Wahren <stefan.wahren@i2se.com> writes:
>> >>
>> >> > Hi Mans,
>> >> >
>> >> >> Mans Rullgard <mans@mansr.com> hat am 10. Januar 2016 um 13:40
>> >> >> geschrieben:
>> >> >>
>> >> >>
>> >> >> Add pinmux setting for USB1 overcurrent on pwm2 pad.
>> >> >
>> >> > could you please change your patch to describe why you need to add
>> >> > this pinmux?
>> >>
>> >> I'm working on a board that is wired that way. I can of course put this
>> >> in the board-specific dts if that's preferable.
>> >
>> > So the board isn't submitted to mainline?
>>
>> Not yet anyway.
>>
>> > IMHO the change is okay, but the description doesn't explain why is it
>> > needed.
>> >
>> > So a suitable description would be that it's needed for board xy.
>>
>> Would it be better to send this patch in a series along with the full
>> board support?
>>
>
> Yes, it would be nice to have a dts file which reference the new pinmux.

OK, I'll sit on it for a while longer then.

-- 
Måns Rullgård