From: mru@kth.se (Måns Rullgård)
To: "David S. Miller" <davem@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [BUG] alignment problem in net/core/flow.c:flow_key_compare
Date: Thu, 18 Mar 2004 20:41:48 +0100 [thread overview]
Message-ID: <yw1xhdwmhrib.fsf@kth.se> (raw)
In-Reply-To: <20040318103004.2cf4de34.davem@redhat.com> (David S. Miller's message of "Thu, 18 Mar 2004 10:30:04 -0800")
"David S. Miller" <davem@redhat.com> writes:
> On Thu, 18 Mar 2004 12:25:57 +0100
> mru@kth.se (Måns Rullgård) wrote:
>
>> mru@kth.se (Måns Rullgård) writes:
>>
>> > The solutions I see are either to force the alignment of struct flowi
>> > to 64 bits, or to use 32-bit access in flow_key_compare.
>>
>> I forgot to mention that this is kernel 2.6.4.
>
> Yes, just add an alignment attribute of some kind to the struct
> is probably the best idea.
What's the proper way of doing that in kernel code? Should I use gcc
__attribute__ directly or is there some macro that's preferred?
--
Måns Rullgård
mru@kth.se
prev parent reply other threads:[~2004-03-18 19:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-18 10:53 Måns Rullgård
2004-03-18 11:25 ` Måns Rullgård
2004-03-18 18:30 ` David S. Miller
2004-03-18 19:41 ` Måns Rullgård [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yw1xhdwmhrib.fsf@kth.se \
--to=mru@kth.se \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome