From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752906AbbLRLYp (ORCPT ); Fri, 18 Dec 2015 06:24:45 -0500 Received: from unicorn.mansr.com ([81.2.72.234]:47620 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751791AbbLRLYm (ORCPT ); Fri, 18 Dec 2015 06:24:42 -0500 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Andy Shevchenko Cc: Julian Margetson , Tejun Heo , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel References: <1450221935-6034-1-git-send-email-mans@mansr.com> <1450364395.30729.136.camel@linux.intel.com> <1450367702.30729.146.camel@linux.intel.com> <1450371184.30729.175.camel@linux.intel.com> <5672F77F.4010306@candw.ms> <567302E8.5050303@candw.ms> <5673061A.4070700@candw.ms> <56732C04.9040100@candw.ms> <1450433310.30729.184.camel@linux.intel.com> Date: Fri, 18 Dec 2015 11:24:32 +0000 In-Reply-To: <1450433310.30729.184.camel@linux.intel.com> (Andy Shevchenko's message of "Fri, 18 Dec 2015 12:08:30 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andy Shevchenko writes: > On Thu, 2015-12-17 at 17:41 -0400, Julian Margetson wrote: >> On 12/17/2015 3:53 PM, Måns Rullgård wrote: >> > Julian Margetson writes: >> > >> > > On 12/17/2015 2:51 PM, Måns Rullgård wrote: >> > > > Julian Margetson writes: >> > > > >> > > > > On 12/17/2015 1:59 PM, Måns Rullgård wrote: >> > > > > > Julian Margetson writes: >> > > > > > >> > > > > > > I have been running my machine mostly configured for >> > > > > > > pciex1  thus with >> > > > > > > the sata_dwc disabled. >> > > > > > > The changes to sata_dwc-460ex do cause an oops. >> > > > > > > I will try to give more detailed info over this weekend . >> > > > > > The driver as is upstream would do that since it >> > > > > > unconditionally >> > > > > > dereferences a null pointer in the probe function.  My >> > > > > > patch fixes that >> > > > > > as a side-effect. >> > > > > > >> > > > > patching file drivers/ata/Kconfig >> > > > > >> > > > > Hunk #1 FAILED at 296. >> > > > [...] >> > > > >> > > > > root@julian-VirtualBox:/usr/src/linux-3.18.25# >> > > > The patch is against 4.4-rc5. >> > > > >> > >  CC      drivers/ata/sata_dwc_460ex.o >> > > >> > > drivers/ata/sata_dwc_460ex.c:198:15: error: variable >> > > ‘sata_dwc_dma_dws’ has initializer but incomplete type >> > > >> > >  static struct dw_dma_slave sata_dwc_dma_dws = { >> > >                ^ >> > It builds, albeit with an unrelated warning, using the attached >> > config. >> > Maybe there's a missing config dependency somewhere. >> > >> I am attempting to cross compile under Ubuntu 14.04 X86 in Virtualbox >> with your .config. >> 4.4.0-rc5 builds ok with no patches applied . >> Once your patch is applied it fails to build . >> CC      drivers/ata/sata_dwc_460ex.o >> drivers/ata/sata_dwc_460ex.c:198:15: error: variable >> ‘sata_dwc_dma_dws’ has initializer but incomplete type >>  static struct dw_dma_slave sata_dwc_dma_dws = { >>                ^ >> drivers/ata/sata_dwc_460ex.c:199:2: error: unknown field ‘src_id’ >> specified in initializer >>   .src_id = 0, > > This clearly means that header file that defines the struct > dw_dma_slave is not included. And yet two lines above there's this: #include This unconditionally defines struct dw_dma_slave. Moreover, the line number in the error message above does not match any version of the file with my patches applied. I suspect something went wrong when Julian patched his tree. > After the patch it seems you have to explicitly enable DW_DMAC, so, > either via make nconfig, or by adding > CONFIG_DW_DMAC=y The option for enabling the compatibility code selects DW_DMAC. There is a missing select DMA_ENGINE, but that won't make any difference here, and my .config has it enabled anyhow. -- Måns Rullgård