From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12F34C43381 for ; Mon, 18 Feb 2019 11:03:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DB140217D7 for ; Mon, 18 Feb 2019 11:03:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730475AbfBRLDh convert rfc822-to-8bit (ORCPT ); Mon, 18 Feb 2019 06:03:37 -0500 Received: from unicorn.mansr.com ([81.2.72.234]:55456 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727058AbfBRLDh (ORCPT ); Mon, 18 Feb 2019 06:03:37 -0500 Received: by unicorn.mansr.com (Postfix, from userid 51770) id 64E7B1630C; Mon, 18 Feb 2019 11:03:35 +0000 (GMT) From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: "Rafael J. Wysocki" Cc: Greg Kroah-Hartman , Linux Kernel Mailing List Subject: Re: [PATCH] platform: set of_node in platform_device_register_full() References: <20190216164512.9525-1-mans@mansr.com> Date: Mon, 18 Feb 2019 11:03:35 +0000 In-Reply-To: (Rafael J. Wysocki's message of "Sun, 17 Feb 2019 22:36:19 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Rafael J. Wysocki" writes: > On Sat, Feb 16, 2019 at 5:50 PM Mans Rullgard wrote: >> >> If the provided fwnode is an OF node, set dev.of_node as well. >> >> Signed-off-by: Mans Rullgard >> --- >> drivers/base/platform.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/base/platform.c b/drivers/base/platform.c >> index dff82a3c2caa..853a1d0e5845 100644 >> --- a/drivers/base/platform.c >> +++ b/drivers/base/platform.c >> @@ -512,6 +512,7 @@ struct platform_device *platform_device_register_full( >> >> pdev->dev.parent = pdevinfo->parent; >> pdev->dev.fwnode = pdevinfo->fwnode; >> + pdev->dev.of_node = of_node_get(to_of_node(pdev->dev.fwnode)); > > of_node_get() generally does a kobject_get() on the node's kobject, so > when is that reference dropped? Or if it doesn't need to be dropped > at all, why is this the case? platform_device_release() calls of_device_node_put(). -- Måns Rullgård