From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753434AbcBEOeJ (ORCPT ); Fri, 5 Feb 2016 09:34:09 -0500 Received: from unicorn.mansr.com ([81.2.72.234]:53458 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752096AbcBEOeI convert rfc822-to-8bit (ORCPT ); Fri, 5 Feb 2016 09:34:08 -0500 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Sebastian Frias Cc: "David S. Miller" , netdev@vger.kernel.org, LKML , mason Subject: Re: [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800 driver References: <56B4A445.7080402@laposte.net> <56B4A877.4020800@laposte.net> <56B4ACC4.1000607@laposte.net> <56B4B013.5030407@laposte.net> Date: Fri, 05 Feb 2016 14:34:00 +0000 In-Reply-To: <56B4B013.5030407@laposte.net> (Sebastian Frias's message of "Fri, 05 Feb 2016 15:22:11 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sebastian Frias writes: > Signed-off-by: Sebastian Frias Please change the subject to something like "net: ethernet: nb8800: support fixed-link DT node" and add a comment body. > --- > drivers/net/ethernet/aurora/nb8800.c | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/aurora/nb8800.c > b/drivers/net/ethernet/aurora/nb8800.c > index ecc4a33..e1fb071 100644 > --- a/drivers/net/ethernet/aurora/nb8800.c > +++ b/drivers/net/ethernet/aurora/nb8800.c > @@ -1460,7 +1460,19 @@ static int nb8800_probe(struct platform_device *pdev) > goto err_disable_clk; > } > > - priv->phy_node = of_parse_phandle(pdev->dev.of_node, "phy-handle", 0); > + if (of_phy_is_fixed_link(pdev->dev.of_node)) { > + ret = of_phy_register_fixed_link(pdev->dev.of_node); > + if (ret < 0) { > + dev_err(&pdev->dev, "bad fixed-link spec\n"); > + goto err_free_bus; > + } > + priv->phy_node = of_node_get(pdev->dev.of_node); > + } > + > + if (!priv->phy_node) > + priv->phy_node = of_parse_phandle(pdev->dev.of_node, > + "phy-handle", 0); > + > if (!priv->phy_node) { > dev_err(&pdev->dev, "no PHY specified\n"); > ret = -ENODEV; > -- > 2.1.4 -- Måns Rullgård