From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756992AbcAJNmN (ORCPT ); Sun, 10 Jan 2016 08:42:13 -0500 Received: from unicorn.mansr.com ([81.2.72.234]:53383 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756592AbcAJNmL convert rfc822-to-8bit (ORCPT ); Sun, 10 Jan 2016 08:42:11 -0500 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Stefan Wahren Cc: Sascha Hauer , Pawel Moll , Rob Herring , Ian Campbell , Kumar Gala , Russell King , linux-kernel@vger.kernel.org, Shawn Guo , Mark Rutland , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2 References: <1452429613-28783-1-git-send-email-mans@mansr.com> <1473600647.505612.cb24b396-67be-4b7b-9938-7cb30ef4fe05.open-xchange@email.1und1.de> <89586980.506110.cb24b396-67be-4b7b-9938-7cb30ef4fe05.open-xchange@email.1und1.de> Date: Sun, 10 Jan 2016 13:42:03 +0000 In-Reply-To: <89586980.506110.cb24b396-67be-4b7b-9938-7cb30ef4fe05.open-xchange@email.1und1.de> (Stefan Wahren's message of "Sun, 10 Jan 2016 14:38:00 +0100 (CET)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Stefan Wahren writes: >> Måns Rullgård hat am 10. Januar 2016 um 14:13 geschrieben: >> >> >> Stefan Wahren writes: >> >> > Hi Mans, >> > >> >> Mans Rullgard hat am 10. Januar 2016 um 13:40 geschrieben: >> >> >> >> >> >> Add pinmux setting for USB1 overcurrent on pwm2 pad. >> > >> > could you please change your patch to describe why you need to add >> > this pinmux? >> >> I'm working on a board that is wired that way. I can of course put this >> in the board-specific dts if that's preferable. > > So the board isn't submitted to mainline? Not yet anyway. > IMHO the change is okay, but the description doesn't explain why is it needed. > > So a suitable description would be that it's needed for board xy. Would it be better to send this patch in a series along with the full board support? -- Måns Rullgård