From: "Måns Rullgård" <mans@mansr.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ethernet: aurora: AURORA_NB8800 should depend on HAS_DMA
Date: Mon, 07 Dec 2015 11:12:21 +0000 [thread overview]
Message-ID: <yw1xk2oqo6lm.fsf@unicorn.mansr.com> (raw)
In-Reply-To: <1449479346-32601-1-git-send-email-geert@linux-m68k.org> (Geert Uytterhoeven's message of "Mon, 7 Dec 2015 10:09:06 +0100")
Geert Uytterhoeven <geert@linux-m68k.org> writes:
> If NO_DMA=y:
>
> ERROR: "dma_map_single" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
> ERROR: "dma_unmap_page" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
> ERROR: "dma_sync_single_for_cpu" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
> ERROR: "dma_unmap_single" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
> ERROR: "dma_alloc_coherent" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
> ERROR: "dma_mapping_error" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
> ERROR: "dma_map_page" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
> ERROR: "dma_free_coherent" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Mans Rullgard <mans@mansr.com>
> drivers/net/ethernet/aurora/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/aurora/Kconfig b/drivers/net/ethernet/aurora/Kconfig
> index a3c7106fdf85e78f..8ba7f8ff3434000f 100644
> --- a/drivers/net/ethernet/aurora/Kconfig
> +++ b/drivers/net/ethernet/aurora/Kconfig
> @@ -13,6 +13,7 @@ if NET_VENDOR_AURORA
>
> config AURORA_NB8800
> tristate "Aurora AU-NB8800 support"
> + depends on HAS_DMA
> select PHYLIB
> help
> Support for the AU-NB8800 gigabit Ethernet controller.
> --
> 1.9.1
>
--
Måns Rullgård
mans@mansr.com
next prev parent reply other threads:[~2015-12-07 11:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 9:09 Geert Uytterhoeven
2015-12-07 11:12 ` Måns Rullgård [this message]
2015-12-07 18:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yw1xk2oqo6lm.fsf@unicorn.mansr.com \
--to=mans@mansr.com \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®