From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754605AbbKMKG0 (ORCPT ); Fri, 13 Nov 2015 05:06:26 -0500 Received: from unicorn.mansr.com ([81.2.72.234]:52054 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753158AbbKMKGX convert rfc822-to-8bit (ORCPT ); Fri, 13 Nov 2015 05:06:23 -0500 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Mason Cc: Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: phy: vitesse: add support for VSC8601 References: <1447353672-4365-1-git-send-email-mans@mansr.com> <5645A48E.9090402@free.fr> Date: Fri, 13 Nov 2015 10:06:19 +0000 In-Reply-To: <5645A48E.9090402@free.fr> (Mason's message of "Fri, 13 Nov 2015 09:51:26 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mason writes: > On 12/11/2015 19:41, Mans Rullgard wrote: > >> + .phy_id = PHY_ID_VSC8601, >> + .name = "Vitesse VSC8601", >> + .phy_id_mask = 0x000ffff0, >> + .features = PHY_GBIT_FEATURES, >> + .flags = PHY_HAS_INTERRUPT, >> + .config_init = &genphy_config_init, >> + .config_aneg = &genphy_config_aneg, >> + .read_status = &genphy_read_status, >> + .ack_interrupt = &vsc824x_ack_interrupt, >> + .config_intr = &vsc82xx_config_intr, > > I expected Documentation/CodingStyle to forbid taking the address > of functions. I can't find anything to that effect. That said, it's not something I would normally do, but all the other phy_driver entries in that file look like that. -- Måns Rullgård mans@mansr.com