From: "Måns Rullgård" <mans@mansr.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Viresh Kumar <vireshk@kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
Vinod Koul <vinod.koul@intel.com>,
dmaengine <dmaengine@vger.kernel.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] dmaengine: dw: fix cyclic transfer callbacks
Date: Mon, 11 Jan 2016 15:22:28 +0000 [thread overview]
Message-ID: <yw1xlh7ww37v.fsf@unicorn.mansr.com> (raw)
In-Reply-To: <CAHp75Vc9Q7P-P7POxgx_srw-uv48dbve2fY-P2Re61MT8YdHUg@mail.gmail.com> (Andy Shevchenko's message of "Mon, 11 Jan 2016 17:17:37 +0200")
Andy Shevchenko <andy.shevchenko@gmail.com> writes:
> On Mon, Jan 11, 2016 at 5:09 PM, Måns Rullgård <mans@mansr.com> wrote:
>> Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:
>>
>>> On Mon, 2016-01-11 at 13:04 +0000, Mans Rullgard wrote:
>>>> Cyclic transfer callbacks rely on block completion interrupts which
>>>> were
>>>> disabled in commit ff7b05f29fd4 ("dmaengine/dw_dmac: Don't handle
>>>> block
>>>> interrupts"). This re-enables block interrupts so the cyclic
>>>> callbacks
>>>> can work. Other transfer types are not affected as they set the
>>>> INT_EN
>>>> bit only on the last block.
>>>>
>>>> Fixes: ff7b05f29fd4 ("dmaengine/dw_dmac: Don't handle block
>>>> interrupts")
>>>> Signed-off-by: Mans Rullgard <mans@mansr.com>
>>>
>>> How did you test that?
>>
>> With the ABDAC sound driver on the AVR32. It fails rather miserably
>> without these patches.
>>
>>> From my understanding the custom stuff that does cyclic interrupts
>>> prepares a set of descriptors per period, which at the end of transfer
>>> will generate XFER interrupt. Next period will go in the same way.
>>>
>>> Maybe I missed something.
>>
>> The cyclic DMA is done by setting up a set of descriptors, one per
>> period, with the last linked back to the first. The chain never ends,
>> so there is never an XFER interrupt.
>
> Thanks for clarification.
>
> Nevertheless, my plan is to get rid of custom implementation of the
> cyclic API in this driver,
Good idea.
> thus, I would suggest to have this patch only for stable and as
> interim for mainline.
Better to start from a working state.
--
Måns Rullgård
next prev parent reply other threads:[~2016-01-11 15:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 13:04 [PATCH v2 0/2] dmaengine: dw: fix cyclic transfers Mans Rullgard
2016-01-11 13:04 ` [PATCH v2 1/2] dmaengine: dw: fix cyclic transfer setup Mans Rullgard
2016-01-11 14:08 ` Viresh Kumar
2016-01-11 13:04 ` [PATCH v2 2/2] dmaengine: dw: fix cyclic transfer callbacks Mans Rullgard
2016-01-11 14:10 ` Viresh Kumar
2016-01-11 14:14 ` Måns Rullgård
2016-01-11 16:08 ` Viresh Kumar
2016-01-14 5:44 ` Vinod Koul
2016-01-11 15:04 ` Andy Shevchenko
2016-01-11 15:09 ` Måns Rullgård
2016-01-11 15:17 ` Andy Shevchenko
2016-01-11 15:22 ` Måns Rullgård [this message]
2016-01-11 15:24 ` Andy Shevchenko
2016-01-14 5:52 ` [PATCH v2 0/2] dmaengine: dw: fix cyclic transfers Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yw1xlh7ww37v.fsf@unicorn.mansr.com \
--to=mans@mansr.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®