From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754238AbbI2VzT (ORCPT ); Tue, 29 Sep 2015 17:55:19 -0400 Received: from unicorn.mansr.com ([81.2.72.234]:35409 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752296AbbI2VzL convert rfc822-to-8bit (ORCPT ); Tue, 29 Sep 2015 17:55:11 -0400 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Mason Cc: Thomas Gleixner , LKML , Daniel Lezcano Subject: Re: Trivial clocksource driver References: <560ABB95.8000404@free.fr> <560AEB32.50006@free.fr> <560AFED6.3020400@free.fr> Date: Tue, 29 Sep 2015 22:55:02 +0100 In-Reply-To: <560AFED6.3020400@free.fr> (Mason's message of "Tue, 29 Sep 2015 23:12:54 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mason writes: > Hello Mans, > > On 29/09/2015 22:18, Måns Rullgård wrote: > >> Mason writes: >> >>> On 29/09/2015 20:32, Thomas Gleixner wrote: >>> >>>> On Tue, 29 Sep 2015, Mason wrote: >>>> >>>>> I am trying to submit a new ARM port, and Arnd pointed out that the >>>>> clocksource code could not live in arch/arm/$PLATFORM, but had to >>>>> move to drivers/clocksource (and it had to support DT). >>>>> >>>>> Did I understand correctly? Is this the right place to submit code >>>>> as provided below? >>>> >>>> Yes, drivers/clocksource is the right place. You just need to submit a >>>> formal patch, which includes a proper subject line, changelog, plus >>>> the necessary Makefile and Kconfig modifications. >>> >>> OK, I'll send a formal patch tomorrow. >>> There are no Kconfig modifications, is that OK? >> >> Why don't you use my driver? It's even simpler, and it works just fine >> on the 87xx chip. >> >> https://github.com/mansr/linux-tangox/blob/master/drivers/clocksource/clksrc-tangox.c > > As you know, I am using two of your complex drivers, namely > ethernet and interrupt controller (which would have taken me > several weeks to write). I will be submitting them upstream > shortly, is that OK with you? I want to test them a bit more on the 87xx first. It's booting, but there are a couple of niggles that should be looked into. Getting some documentation would expedite that process. > I'm not using this particular driver of yours because I had > already written the code, and porting it to DT was a good > learning process. This is probably my only opportunity to > actually write any kind of code for this port. You should still be using the existing clocksource_mmio helper. In fact, that interface could be exposed using a generic DT binding. -- Måns Rullgård mans@mansr.com