From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761715AbcALIvK (ORCPT ); Tue, 12 Jan 2016 03:51:10 -0500 Received: from unicorn.mansr.com ([81.2.72.234]:57759 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932525AbcALIvJ convert rfc822-to-8bit (ORCPT ); Tue, 12 Jan 2016 03:51:09 -0500 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Cyrille Pitchen Cc: , "Yang\, Wenyou" , Nicolas Ferre , Mark Brown , , Subject: Re: [PATCH v2] spi: atmel: improve internal vs gpio chip-select choice References: <1452528102-26458-1-git-send-email-mans@mansr.com> <5694BBCD.8020700@atmel.com> Date: Tue, 12 Jan 2016 08:51:00 +0000 In-Reply-To: <5694BBCD.8020700@atmel.com> (Cyrille Pitchen's message of "Tue, 12 Jan 2016 09:39:41 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Cyrille Pitchen writes: > Hi Mans, > > I've tried to apply your patch on a next-20160112 branch to test it but it > failed. I've also looked at the for-next branch of the SPI sub-system git > tree. > > It seems that one issue occurred within a chunk patching the atmel_spi_setup() > function. Please see below. > > Le 11/01/2016 17:01, Mans Rullgard a écrit : > [...] >> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c >> index 08cbb3e43c76..d4a806e24060 100644 >> --- a/drivers/spi/spi-atmel.c >> +++ b/drivers/spi/spi-atmel.c > [...] >> @@ -1603,6 +1611,7 @@ static int atmel_spi_setup(struct spi_device *spi) >> } >> >> asd->npcs_pin = npcs_pin; >> + asd->use_cs_gpio = use_cs_gpio; >> spi->controller_state = asd; >> } else { >> atmel_spi_lock(as); > [...] > > There is no 'else' statement in the source code I'm looking at. Sorry, I'll send a new patch against the correct base. I forgot I had something else earlier in my local branch. -- Måns Rullgård